forgejo/docs

Fork 249

Code Issues 61 Pull requests 37 Activity Actions

admin: installation: remote data folder (#193) #194

Merged

earl-warren merged 1 commit from pr/v1.21/admin/installation into v1.21

2023年10月15日 14:49:26 +02:00

Conversation 7 Commits 1 Files changed 1 +124 -21

earl-warren commented

2023年10月14日 19:48:16 +02:00

Contributor

Copy link

Preview: https://forgejo.codeberg.page/@docs_pull_194/docs/next/admin/installation/#hosting-repository-data-on-remote-storage-systems

Documentation proposal for remote data mounting, following up from forgejo/forgejo#1590

Co-authored-by: Daniel Bischof daniel.bischof@protonmail.com
Reviewed-on: #193
Reviewed-by: Earl Warren earl-warren@noreply.codeberg.org
Co-authored-by: dbischof90 dbischof90@noreply.codeberg.org
Co-committed-by: dbischof90 dbischof90@noreply.codeberg.org
(cherry picked from commit cabb9fca11)

Preview: https://forgejo.codeberg.page/@docs_pull_194/docs/next/admin/installation/#hosting-repository-data-on-remote-storage-systems Documentation proposal for remote data mounting, following up from https://codeberg.org/forgejo/forgejo/issues/1590 Co-authored-by: Daniel Bischof <daniel.bischof@protonmail.com> Reviewed-on: https://codeberg.org/forgejo/docs/pulls/193 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: dbischof90 <dbischof90@noreply.codeberg.org> Co-committed-by: dbischof90 <dbischof90@noreply.codeberg.org> (cherry picked from commit cabb9fca11e0babcae88f365ce669d5159bc3e67)

earl-warren added 1 commit

2023年10月14日 19:48:18 +02:00

admin: installation: remote data folder ( #193 )

All checks were successful

pr / preview (pull_request) Successful in 1m2s

Details

backport / backport (pull_request) Successful in 2s

Details

push / publish (push) Successful in 13s

Details

c9ee7d39e4

Documentation proposal for remote data mounting, following up from forgejo/forgejo#1590
Co-authored-by: Daniel Bischof <daniel.bischof@protonmail.com>
Reviewed-on: #193
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: dbischof90 <dbischof90@noreply.codeberg.org>
Co-committed-by: dbischof90 <dbischof90@noreply.codeberg.org>
(cherry picked from commit cabb9fca11)

forgejo-website commented

2023年10月14日 19:49:25 +02:00

Collaborator

Copy link

Preview ready: https://forgejo.codeberg.page/@docs_pull_194/

earl-warren requested review from dbischof90

2023年10月14日 20:52:58 +02:00

dbischof90 commented

2023年10月14日 21:09:19 +02:00

Contributor

Copy link

Preview ready: https://forgejo.codeberg.page/@docs_pull_194/

Is your bot working correctly? This link does not contain my changes... only the one @earl-warren posted.

> Preview ready: https://forgejo.codeberg.page/@docs_pull_194/ Is your bot working correctly? This link does not contain my changes... only the one @earl-warren posted.

earl-warren commented

2023年10月14日 21:18:08 +02:00

Author

Contributor

Copy link

https://forgejo.codeberg.page/@docs_pull_194/docs/next/admin/installation/#hosting-repository-data-on-remote-storage-systems it shows but you have to navigate to find it. The link I posted also works but is not canonical.

dbischof90 commented

2023年10月14日 23:19:44 +02:00

Contributor

Copy link

I have another detail, maybe it’s faster for you to change: in the NFS server setting it has to be [...],sec=sys instead of [...],ec=sys:

Correct entry should be

[...]
/repositories	*(rw,sync,all_squash,sec=sys,anonuid=1024,anongid=100)

I have another detail, maybe it’s faster for you to change: in the NFS server setting it has to be `[...],sec=sys` instead of `[...],ec=sys`: Correct entry should be ```shell [...] /repositories *(rw,sync,all_squash,sec=sys,anonuid=1024,anongid=100) ```

rome-user requested changes

2023年10月15日 01:47:33 +02:00

rome-user left a comment

Copy link

Only one major issue, but the rest of my comments are nitpicks.

docs/admin/installation.md

@ -149,0 +195,4 @@

$ mkdir data

```

To consider in the client setup is the `hard` setting, blocking all file operations if the share is not available.

rome-user commented

2023年10月15日 01:36:01 +02:00

First-time contributor

Copy link

I don't understand the first part of this sentence. Does "in the client setup" mean "in-the-client setup" or something else?

rome-user marked this conversation as resolved

docs/admin/installation.md

@ -149,0 +199,4 @@

This prevents state changes in the repository which could potentially corrupt the repository data and is an NFS-specific setting.

To circumvent this, you can use the

We will use the `rootless` image, which hosts the `ssh` server for Forgejo embedded. A possible entry for a `docker-compose` file

rome-user commented

2023年10月15日 01:38:49 +02:00

First-time contributor

Copy link

On the rendered site, this appears as:

To circumvent this, you can use the We will use the rootless image, ...

I think we can delete line 201 given the NFS mount above.

On the rendered site, this appears as: > To circumvent this, you can use the We will use the `rootless` image, ... I think we can delete line 201 given the NFS mount above.

rome-user marked this conversation as resolved

docs/admin/installation.md

@ -149,0 +227,4 @@

- - ./forgejo:/var/lib/gitea

+ - /mnt/repositories/data:/var/lib/gitea

+ - /mnt/repositories/conf:/etc/gitea

- /etc/timezone:/etc/timezone:ro

rome-user commented

2023年10月15日 01:42:17 +02:00

First-time contributor

Copy link

The diff is subtly incorrect in services.volumes. There are no whitespace changes in e.g. services.server.image, but there are here.

The diff is subtly incorrect in `services.volumes`. There are no whitespace changes in e.g. `services.server.image`, but there are here.

rome-user marked this conversation as resolved

docs/admin/installation.md

@ -149,0 +247,4 @@

Note that this is a comparatively simple setup which does not necessarily reflect the reality of your network.

User mapping and ownership could theoretically be streamlined better with Kerberos, which is however out of scope

for this guide.

rome-user commented

2023年10月15日 01:46:33 +02:00

First-time contributor

Copy link

I recommend simplifying this to

Note this setup is simple and does not necessarily reflect the reality of your network. User mapping and ownership could be streamlined better with Kerberos, but that is out of the scope of this guide.

I recommend simplifying this to > Note this setup is simple and does not necessarily reflect the reality of your network. User mapping and ownership could be streamlined better with Kerberos, but that is out of the scope of this guide.

rome-user marked this conversation as resolved

Ghost approved these changes

2023年10月15日 14:41:26 +02:00

earl-warren commented

2023年10月15日 14:49:13 +02:00

Author

Contributor

Copy link

Since this is a backport, I opened another PR at #195 with the suggested modifications, for discussion also. 👍

Since this is a backport, I opened another PR at https://codeberg.org/forgejo/docs/pulls/195 with the suggested modifications, for discussion also. 👍

earl-warren merged commit c9ee7d39e4 into v1.21

2023年10月15日 14:49:26 +02:00