forgejo-contrib/forgejo-cli
20
407
Fork
You've already forked forgejo-cli
51

chore: run clippy #484

Merged
Cyborus merged 6 commits from ci/clippy into main 2026年06月03日 21:31:20 +02:00
Member
Copy link

Changes Made

Adds clippy to the CI checks, and fixes the existing issues it found.

Code of Conduct

  • I agree to act in accordance with the CoC & AI Agreement.
  • This contribution was not generated by an LLM, even in part.
### Changes Made Adds clippy to the CI checks, and fixes the existing issues it found. ### Code of Conduct - [x] I agree to act in accordance with the CoC & AI Agreement. - [x] This contribution was not generated by an LLM, even in part. 
The result of running `clippy --fix`
chore: manual clippy fixes
Some checks failed
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline failed
ci/woodpecker/pr/check-clippy Pipeline was successful
43aefdfe4c
chore: fmt
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
f35fea8777
LordMZTE requested changes 2026年06月03日 18:59:21 +02:00
Dismissed
LordMZTE left a comment
Copy link

It's a great idea to run Clippy in the CI! A few questions/nitpicks :D

It's a great idea to run Clippy in the CI! A few questions/nitpicks :D
@ -0,0 +1,9 @@
when:
Collaborator
Copy link

Any reason taht this is a separate workflow and not just an extra step in check? Seems to me like we might get faster CI runs if we put that in there.

Any reason taht this is a separate workflow and not just an extra step in `check`? Seems to me like we might get faster CI runs if we put that in there.
Author
Member
Copy link

I did that so it would show as its own check on a PR's page, making clear at a glance what it was that failed. I considered pulling the fmt check out into its own workflow for that same reason. Having them separate might also be faster since each one could be run by a different runner concurrently, though I don't imagine it actually takes long enough for that to be a huge deal.

I did that so it would show as its own check on a PR's page, making clear at a glance what it was that failed. I considered pulling the `fmt` check out into its own workflow for that same reason. Having them separate might also be faster since each one could be run by a different runner concurrently, though I don't imagine it actually takes long enough for that to be a huge deal.
LordMZTE marked this conversation as resolved
src/auth.rs Outdated
@ -296,6 +294,7 @@ async fn oauth_login(
usetokio::{sync::mpsc::Receiver,task::JoinHandle};
#[allow(clippy::type_complexity)]
Collaborator
Copy link

This lint seems entirely reasonable. I have no clue what the Result<Option<(String, String)>, String>> represents :P

We should consider introducing a type alias or (tuple-) struct.

This lint seems entirely reasonable. I have no clue what the `Result<Option<(String, String)>, String>>` represents :P We should consider introducing a type alias or (tuple-) struct.
LordMZTE marked this conversation as resolved
refactor(oauth): break up complex return type
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
c4defdbef0
Cyborus deleted branch ci/clippy 2026年06月03日 21:31:21 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Design
Discussion about UI/UX design
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Kind/Upstream
This is an issue with upstream software (Forgejo) that is probably not our fault
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Suspicious
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo-contrib/forgejo-cli!484
Reference in a new issue
forgejo-contrib/forgejo-cli
No description provided.
Delete branch "ci/clippy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?