Currently the errors are just base eyre reports. this could be a lot nicer
better error printing #112
Hey,
could I take on this task?
I'm currently on my way of using/learning Rust and thought that might be a good opportunity to use what I've learned from the rust book and other resources. Only if you don't mind of course.
Absolutely welcome to take a shot at it!
That is great to hear. 👍
Your initial message is not very clear about the issue.
Could you explain in more detail what you are trying to achieve and perhaps give a brief example?
I haven't put a lot of thought into the details of what I'd like in it yet. In general, I'd like it to do the following:
- Be more clear when the user has done something incorrectly, and when something else is going wrong.
- If the user has some something incorrect, it should do what it can to direct them to fixing it.
- Prettier display, i.e. colors.
If you happen to have any ideas, I'm happy to listen to them
@dataCobra any updates?
No, I've been reading the eyre docs but because of not enough free time didn't updated anything.
Alright! no worries, just thought I'd check in.
@dataCobra any progress?
Because of private duties I was unable to progress any further.
At the moment I'm also not able to tell when I might get back on track.
Sorry for the inconvenience.
That's fine, I totally understand. I'll probably get around to this myself sometime, then. Take care!
I was going to open a new issue but it seems like this would explain the:
Error: no repo info specified
Location:
src/repo.rs:202:29
error for nearly every command from fj auth to fj repo create
At first I thought git init was required or I needed to specify codeberg.org in some way. But it seems it's the error reporting.
I'm on NixOS btw.
DISTRIB_DESCRIPTION="NixOS 26.05 (Yarara)"
@fuguesoft wrote in #112 (comment):
At first I thought
git initwas required or I needed to specifycodeberg.orgin some way.
Yes, you do need to do at least one of those. The errors aren't happening incorrectly, they're just unhelpful.
This is what I'm experiencing
https://asciinema.org/a/pIAEiwrIx3npWs7W
v0.4.1
I see that the fj auth login block is fixed in 5.0
And I am able to login by generating a token and doing fj auth add-key
That one particular error of "no repo information specified" seems maybe more like a bug?
I say this because the other errors seemed varied and somewhat useful
The "no repo info specified" error in particular should've been improved since !278. It's a bit more clear why it happens now.
Hi, I'd like to take this one. I've checked how other CLI tools handle errors and may have just enough time over the next week to implement this
Feel free! Glad to have contributions on this
@SLASHLogin I would like to let you know this is something that's likely to be affected by !279, which is very close to merging, so may be worth waiting for that.
It's merged, you're good to go
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?