error with renewing session #273

fkooman commented 2025年07月09日 10:49:00 +02:00

A bug was discovered when using the "Renew" button with the 4.4 client. So far I only tested with OpenVPN, there it occurs, but maybe not with WireGuard, I didn't test yet, will do shortly.

Steps to reproduce:

1. Add + Connect to vpn.tuxed.net ("FrKo's Test Server")
2. Use the "OpenVPN (TCP Only) Profile
3. Wait 30 minutes for the "Renew" button to appear
4. Click it
5. Error is shown

The stack trace of the error:

System.Exception: Ein interner Fehler ist aufgetreten. Die Fehlerursache ist: fsm invalid transition attempt from 'Disconnecting' to 'OAuthStarted'.
 bei eduVPN.Engine.RenewSession(Cookie cookie)
 bei eduVPN.ViewModels.Windows.ConnectWizard.<>c__DisplayClass72_0.<RenewAndConnect>b__0()
 bei System.Threading.Tasks.Task`1.InnerInvoke()
 bei System.Threading.Tasks.Task.Execute()
--- Ende der Stapelüberwachung vom vorhergehenden Ort, an dem die Ausnahme ausgelöst wurde ---
 bei System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
 bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
 bei eduVPN.ViewModels.Windows.ConnectWizard.<RenewAndConnect>d__72.MoveNext()
--- Ende der Stapelüberwachung vom vorhergehenden Ort, an dem die Ausnahme ausgelöst wurde ---
 bei System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
 bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
 bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Screenshots:

image

image

A bug was discovered when using the "Renew" button with the 4.4 client. So far I only tested with OpenVPN, there it occurs, but maybe not with WireGuard, I didn't test yet, will do shortly. Steps to reproduce: 1. Add + Connect to vpn.tuxed.net ("FrKo's Test Server") 2. Use the "OpenVPN (TCP Only) Profile 3. Wait 30 minutes for the "Renew" button to appear 4. Click it 5. Error is shown The stack trace of the error: ``` System.Exception: Ein interner Fehler ist aufgetreten. Die Fehlerursache ist: fsm invalid transition attempt from 'Disconnecting' to 'OAuthStarted'. bei eduVPN.Engine.RenewSession(Cookie cookie) bei eduVPN.ViewModels.Windows.ConnectWizard.<>c__DisplayClass72_0.<RenewAndConnect>b__0() bei System.Threading.Tasks.Task`1.InnerInvoke() bei System.Threading.Tasks.Task.Execute() --- Ende der Stapelüberwachung vom vorhergehenden Ort, an dem die Ausnahme ausgelöst wurde --- bei System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() bei System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) bei eduVPN.ViewModels.Windows.ConnectWizard.<RenewAndConnect>d__72.MoveNext() --- Ende der Stapelüberwachung vom vorhergehenden Ort, an dem die Ausnahme ausgelöst wurde --- bei System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs) bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler) ``` Screenshots:  

fkooman commented 2025年07月09日 10:54:15 +02:00

Update: it also occurs with WireGuard, I tested with the "Default" Profile of that same server.

Update: it also occurs with WireGuard, I tested with the "Default" Profile of that same server.

rozmansi commented 2025年07月09日 11:25:57 +02:00

Ahh, this eduvpn-common is such a royal PITA when it comes to FSM transition checking. Will fix it.

Ahh, this eduvpn-common is such a royal PITA when it comes to FSM transition checking. Will fix it.

dohl commented 2025年07月10日 09:29:21 +02:00

Hi,

One of our students has a similar error.
Here is the screenshot.
Unfortunately I have no further information.
Is there a workaround?
Could this be the same error?

Hi, One of our students has a similar error. Here is the screenshot. Unfortunately I have no further information. Is there a workaround? Could this be the same error?

fkooman commented 2025年07月10日 10:28:19 +02:00

We've pulled the 4.4 release:

https://lists.geant.org/sympa/arc/eduvpn-deploy/2025-07/msg00007.html

We've pulled the 4.4 release: https://lists.geant.org/sympa/arc/eduvpn-deploy/2025-07/msg00007.html

fkooman commented 2025年08月01日 22:31:20 +02:00

I'm unable to reproduce the problem with 4.4.99.1, so looking good!

I'm unable to reproduce the problem with 4.4.99.1, so looking good!

rozmansi commented 2025年08月02日 07:51:49 +02:00

@dohl wrote in #273 (comment):

Hi,

One of our students has a similar error. Here is the screenshot. Unfortunately I have no further information. Is there a workaround? Could this be the same error?

No, this is a different error. Missed this. Reusing this issue to remind me to fix it...

@dohl wrote in https://codeberg.org/eduVPN/windows/issues/273#issuecomment-5775026: > Hi, > > One of our students has a similar error. Here is the screenshot. Unfortunately I have no further information. Is there a workaround? Could this be the same error? No, this is a different error. Missed this. Reusing this issue to remind me to fix it...

fkooman commented 2025年08月04日 09:37:07 +02:00

I've just tested out that test release client 4.4.99.1 and am happy to report that works well for me and I can renew the session successfully.

Got feedback from the initial reporter of this issue.

> I've just tested out that test release client 4.4.99.1 and am happy to report that works well for me and I can renew the session successfully. Got feedback from the initial reporter of this issue.

rozmansi commented 2025年08月05日 14:46:48 +02:00

@dohl wrote in #273 (comment):

Hi,

One of our students has a similar error. Here is the screenshot. Unfortunately I have no further information. Is there a workaround? Could this be the same error?

<TLDR>

This issue can happen if:

1. edu-vpn.uni-erfurt.de provided an incorrect OAuth URL. Somehow unlikely, as this would make all other users suffer the same error.
2. System.Diagnostics.Process.Start throws:
   • Something blocks opening URLs. An antivirus?
   • User has no default browser to open https:// URLs set. Or, just uninstalled what used to be the default browser and has not set a new one yet.
   • This one is interesting - according to the documentation, this function may throw System.IO.FileNotFoundException if "The PATH environment variable has a string containing quotes." Might explain some other situations we hit in the past when opening URLs from the client just doesn't work.

Nevertheless, throwing when OAuth page should be presented to the user, is caught not to disturb Go-CGo-.NET interop. But the eduvpn-common is notified the FSM transition failed, ultimately resulting in the client to display the error message user is seeing: the FSM transition failed.

image

</TLDR>

I have updated the client code to ignore browser launch issues, since the client has a solution for broken computers with this issue.

Will notify here when I make a new release (estimated by the end of this week), so your student may try again.

After updating the client, clicking on the university server will likely fail to open university's OAuth website for this student, but the client will stop on a page looking like this:
image
(Instructions included 😎)

@dohl wrote in https://codeberg.org/eduVPN/windows/issues/273#issuecomment-5775026: > Hi, > > One of our students has a similar error. Here is the screenshot. Unfortunately I have no further information. Is there a workaround? Could this be the same error? `<TLDR>` This issue can happen if: 1. `edu-vpn.uni-erfurt.de` provided an incorrect OAuth URL. Somehow unlikely, as this would make all other users suffer the same error. 2. `System.Diagnostics.Process.Start` throws: - Something blocks opening URLs. An antivirus? - User has no default browser to open `https://` URLs set. Or, just uninstalled what used to be the default browser and has not set a new one yet. - This one is interesting - according to the documentation, this function may throw `System.IO.FileNotFoundException` if _"The PATH environment variable has a string containing quotes."_ Might explain some other situations we hit in the past when opening URLs from the client just doesn't work. Nevertheless, throwing when OAuth page should be presented to the user, is caught not to disturb Go-CGo-.NET interop. But the eduvpn-common is notified the FSM transition failed, ultimately resulting in the client to display the error message user is seeing: the FSM transition failed.  `</TLDR>` I have updated the client code to ignore browser launch issues, since the client has a solution for broken computers with this issue. Will notify here when I make a new release (estimated by the end of this week), so your student may try again. After updating the client, clicking on the university server will likely fail to open university's OAuth website for this student, but the client will stop on a page looking like this:  (Instructions included 😎)

rozmansi commented 2025年08月05日 15:26:39 +02:00

@rozmansi wrote in #273 (comment):

Will notify here when I make a new release (estimated by the end of this week), so your student may try again

Was testing the buildsystem and a perfectly fine release came out. So this was sooner than announced:
https://codeberg.org/eduVPN/windows/releases/tag/4.4.99.2

@rozmansi wrote in https://codeberg.org/eduVPN/windows/issues/273#issuecomment-6134323: > Will notify here when I make a new release (estimated by the end of this week), so your student may try again Was testing the buildsystem and a perfectly fine release came out. So this was sooner than announced: https://codeberg.org/eduVPN/windows/releases/tag/4.4.99.2