10
9
Fork
You've already forked linux-app
14

UX: Client doesn't handle other configured VPNs correctly #464

Closed
opened 2022年03月04日 16:34:24 +01:00 by Lukas-UAUX · 12 comments
Lukas-UAUX commented 2022年03月04日 16:34:24 +01:00 (Migrated from github.com)
Copy link

Installation

How did you install the eduVPN client?

-> Via the repository

Version

What version of the client you are running? Try your package manager or otherwise $ eduvpn-client -v.

-> 2.2.1-1

OS/Distribution

What operating system/distribution and version you are running?

-> Ubuntu 20.04.4

Do you have a problem during connecting?

The gui can not differentiate between its own and another NetworkManager VPN. If any VPN is Connected the App shows a valid connection. The switch could be turned off resulting in a disconnected message bot obviously does nothing with the active connection.

When both Connections are active disconnecting doesn't work at all. I have to manually use the network settings to disconnect.

# Installation How did you install the eduVPN client? -> Via the repository # Version What version of the client you are running? Try your package manager or otherwise `$ eduvpn-client -v`. -> 2.2.1-1 # OS/Distribution What operating system/distribution and version you are running? -> Ubuntu 20.04.4 ## Do you have a problem during connecting? The gui can not differentiate between its own and another NetworkManager VPN. If any VPN is Connected the App shows a valid connection. The switch could be turned off resulting in a disconnected message bot obviously does nothing with the active connection. When both Connections are active disconnecting doesn't work at all. I have to manually use the network settings to disconnect.
alvra commented 2022年03月21日 16:24:19 +01:00 (Migrated from github.com)
Copy link

This should be improved with #466. Specifically, on startup, the network state was not specific to the connection managed by the app.

Does this solve your issue?

This should be improved with #466. Specifically, on startup, the network state was not specific to the connection managed by the app. Does this solve your issue?
martijnkruiten commented 2022年03月22日 09:13:49 +01:00 (Migrated from github.com)
Copy link

I'm going to piggyback on this issue, but I'll happily create a new issue if it's not relevant to this one.

When both Connections are active disconnecting doesn't work at all. I have to manually use the network settings to disconnect.

The client can't disconnect the connection even if the only active connection is the eduVPN connection, at least not on Fedora 35. That's especially bothersome if you have to renew your connection and the authentication server is included in the routes that are pushed by the VPN server, because then the authentication page won't load, unless you disconnect the VPN manually in the OS. I can imagine that this is also related to the client not being able to differentiate between VPN connections. I haven't tested #466 yet.

I'm going to piggyback on this issue, but I'll happily create a new issue if it's not relevant to this one. > When both Connections are active disconnecting doesn't work at all. I have to manually use the network settings to disconnect. The client can't disconnect the connection even if the only active connection is the eduVPN connection, at least not on Fedora 35. That's especially bothersome if you have to renew your connection and the authentication server is included in the routes that are pushed by the VPN server, because then the authentication page won't load, unless you disconnect the VPN manually in the OS. I can imagine that this is also related to the client not being able to differentiate between VPN connections. I haven't tested #466 yet.
martijnkruiten commented 2022年03月22日 09:25:57 +01:00 (Migrated from github.com)
Copy link

I've tested the latest commit from the wireguard branch and that doesn't fix both issues. It still says "connection active" when I connect another VPN and the client still can't disconnect its own VPN.

I've tested the latest commit from the wireguard branch and that doesn't fix both issues. It still says "connection active" when I connect another VPN and the client still can't disconnect its own VPN.
martijnkruiten commented 2022年03月22日 09:28:10 +01:00 (Migrated from github.com)
Copy link

Possibly related:

2022年03月22日 09:27:23,963 - run-periodically - WARNING - eduvpn.ui.stats - stats.py:108 - Network Stats: rx_bytes, failed to get interface
2022年03月22日 09:27:23,964 - run-periodically - WARNING - eduvpn.ui.stats - stats.py:108 - Network Stats: tx_bytes, failed to get interface
Segmentation fault (core dumped)
Possibly related: ``` 2022年03月22日 09:27:23,963 - run-periodically - WARNING - eduvpn.ui.stats - stats.py:108 - Network Stats: rx_bytes, failed to get interface 2022年03月22日 09:27:23,964 - run-periodically - WARNING - eduvpn.ui.stats - stats.py:108 - Network Stats: tx_bytes, failed to get interface Segmentation fault (core dumped) ```
alvra commented 2022年03月22日 15:36:48 +01:00 (Migrated from github.com)
Copy link

I believe the cause for this issue is this call: github.com/eduvpn/python-eduvpn-client@e20c0da22d/eduvpn/nm.py (L310)
(and other calls to get_primary_connection() in this file).
which uses the primary connection instead of the one managed by the app, as I ran into similar problems working on wireguard. The PR I mentioned (#466) only solves the issue on startup, but not on disconnect.

@martijnkruiten Your last message seems like an unrelated bug to me. Feel free to open a separate issue for this.

I believe the cause for this issue is this call: https://github.com/eduvpn/python-eduvpn-client/blob/e20c0da22d937c1052b0ad5bd79d9b92fc9bd599/eduvpn/nm.py#L310 (and other calls to `get_primary_connection()` in this file). which uses the primary connection instead of the one managed by the app, as I ran into similar problems working on wireguard. The PR I mentioned (#466) only solves the issue on startup, but not on disconnect. @martijnkruiten Your last message seems like an unrelated bug to me. Feel free to open a separate issue for this.
Lukas-UAUX commented 2022年03月22日 17:05:36 +01:00 (Migrated from github.com)
Copy link

Do I need to compile/build from source to test this change or are there automated builds somewhere I can download?

Do I need to compile/build from source to test this change or are there automated builds somewhere I can download?
gijzelaerr commented 2022年04月22日 15:56:42 +02:00 (Migrated from github.com)
Copy link

hi @Lukas-UAUX, you need to clone the repo, checkout the right branch and run make eduvpn-gui to test a pre-release or specific branch. Can you let us know if your issue is resolved?

hi @Lukas-UAUX, you need to clone the repo, checkout the right branch and run `make eduvpn-gui` to test a pre-release or specific branch. Can you let us know if your issue is resolved?
Lukas-UAUX commented 2022年04月25日 18:49:39 +02:00 (Migrated from github.com)
Copy link

I uninstalled eduvpn, checked out master and ran the make command. As far as I can tell the experience just got more weird. It now automatically stacks the eduvpn connection on top of the existing connection (which is good I think) but the disconnect still does not work, it stays connected - after a few seconds the indicator switches back to green. The taskbar applets of the NetworkManager just stop working (the indicators and controls behave completely erratic) and I need to use my DE's settings panel to stop the connections.

I uninstalled eduvpn, checked out master and ran the make command. As far as I can tell the experience just got more weird. It now automatically stacks the eduvpn connection on top of the existing connection (which is good I think) but the disconnect still does not work, it stays connected - after a few seconds the indicator switches back to green. The taskbar applets of the NetworkManager just stop working (the indicators and controls behave completely erratic) and I need to use my DE's settings panel to stop the connections.
gijzelaerr commented 2022年04月26日 08:11:20 +02:00 (Migrated from github.com)
Copy link

Thank you for checking. can you remove the config (rm -rf ~/.config/eduvpn) and manually remove the VPN connections from network manager and try again?

Thank you for checking. can you remove the config (`rm -rf ~/.config/eduvpn`) and manually remove the VPN connections from network manager and try again?
Lukas-UAUX commented 2022年05月30日 11:28:16 +02:00 (Migrated from github.com)
Copy link

With the newest master of today and now Ubuntu 22.04 it seems to work much more stable, connecting and disconnecting on top of my other VPN connection now works fine. The other way around though doesn't - the client instantly reconnects the eduVPN connection so it keeps being the only active connection although this scenario is much, much less likely to be actually used...

With the newest master of today and now Ubuntu 22.04 it seems to work much more stable, connecting and disconnecting on top of my other VPN connection now works fine. The other way around though doesn't - the client instantly reconnects the eduVPN connection so it keeps being the only active connection although this scenario is much, much less likely to be actually used...
jwijenbergh commented 2022年06月16日 13:34:39 +02:00 (Migrated from github.com)
Copy link

Could you test #495? Should be much better now

Could you test #495? Should be much better now
jwijenbergh commented 2022年06月22日 14:31:57 +02:00 (Migrated from github.com)
Copy link

This issue should be fixed, if it's not let us know @Lukas-UAUX

This issue should be fixed, if it's not let us know @Lukas-UAUX
Sign in to join this conversation.
No Branch/Tag specified
master
upstream-deb
openvpn-persistent
1.x
4.7.2
4.7.1
4.7.0
4.6.0
4.5.1
4.5.0
4.4.99.0
4.4.0
4.3.1
4.3.0
4.2.99.1
4.2.99.0
4.2.1
4.2.0
4.1.99.0
4.1.3
4.1.2
4.1.1
4.1.0
3.1.1
4.0.1
4.0.0
pr-3.3.1
pr-3.3.0
pr-3.2.0
3.1.0
3.0.0
2.2.1
2.2.0
2.1.0
2.0.0
1.1
1.0.3
1.0.2
1.0.1
1.0rc17
1.0rc16
1.0rc15
1.0rc14
1.0rc13
1.0rc12
1.0rc11
1.0rc10
1.0rc9
1.0rc8
1.0rc7
1.0rc6
1.0rc5
1.0rc4
1.0rc3
1.0rc2
1.0rc1
0.8
0.7.2
0.7.1
0.7
0.6.1
0.6
0.5.1
0.5
0.3
0.2.1
0.2
0.1.1
0.1
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eduVPN/linux-app#464
Reference in a new issue
eduVPN/linux-app
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?