License page update #57

Mino5531 commented 2026年04月14日 19:07:32 +02:00

• Implement new license page with updated licenses for the dependencies using the aboutLibraries library.
• Set minSdk to 23 (Android 6) to be able to use jetpack compose and composeView
  closes: #23

- Implement new license page with updated licenses for the dependencies using the aboutLibraries library. - Set minSdk to 23 (Android 6) to be able to use jetpack compose and composeView closes: #23

fkooman commented 2026年04月14日 21:50:05 +02:00

Thanks!

How are the JSON files generated under aboutLibrariesConfig/libraries? Is that the result of some tool running?

Can this also work without adding a new dependency? It doesn't have to be fancy :)

Thanks! How are the JSON files generated under `aboutLibrariesConfig/libraries`? Is that the result of some tool running? Can this also work _without_ adding a new dependency? It doesn't have to be fancy :)

Mino5531 commented 2026年04月14日 22:03:11 +02:00

The JSON files under aboutLibrariesConfig/libraries are currently written by hand because there were either no tools to do that task automatically (eduvpn-common, ics-openvpn, wireguard) or the tools that do exist don't really work reliably or only work for projects on GitHub (Go dependencies).

The main JSON file which contains all the merged data (so the manually written JSON files and the automatically detected dependencies) is located at app/src/main/assets/aboutLibraries.json and is generated by running ./gradlew exportLibraryDefinitions.

It is possible to create a license page without using the UI part of the aboutLibraries dependency; however, the dependency is also used for collecting all the data about the Android dependencies (JUnit, OkHttp, etc.).

The JSON files under `aboutLibrariesConfig/libraries` are currently written by hand because there were either no tools to do that task automatically (eduvpn-common, ics-openvpn, wireguard) or the tools that do exist don't really work reliably or only work for projects on GitHub (Go dependencies). The main JSON file which contains all the merged data (so the manually written JSON files and the automatically detected dependencies) is located at `app/src/main/assets/aboutLibraries.json` and is generated by running `./gradlew exportLibraryDefinitions`. It is possible to create a license page without using the UI part of the `aboutLibraries` dependency; however, the dependency is also used for collecting all the data about the Android dependencies (JUnit, OkHttp, etc.).

Mino5531 commented 2026年04月22日 16:13:31 +02:00

Should I update the build scripts, so that they rebuild the aboutLibraries.json file every time, before we merge this?

Should I update the build scripts, so that they rebuild the `aboutLibraries.json` file every time, before we merge this?

dzolnai commented 2026年04月22日 16:42:06 +02:00

Yes please, otherwise I'm afraid it would be often forgotten :)

Yes please, otherwise I'm afraid it would be often forgotten :)

Mino5531 commented 2026年04月22日 20:56:48 +02:00

Alright, I have added the task exportLibraryDefinitions as a dependency for all release related tasks which should ensure that the aboutLibraries.json file is always up to date for release builds

Alright, I have added the task `exportLibraryDefinitions` as a dependency for all release related tasks which should ensure that the `aboutLibraries.json` file is always up to date for release builds

dzolnai commented 2026年04月23日 10:09:15 +02:00

Thanks for the update and your contribution in general.
I tested it, and it works fine, looks nice as well, both in light and dark mode.

Thanks for the update and your contribution in general. I tested it, and it works fine, looks nice as well, both in light and dark mode.