Return a success exit code if the user closed the launcher #98

tinywrkb commented 2022年02月04日 20:52:47 +01:00

I'm not sure if this is a bug or a request feature, and I haven't went through the code, and try to understand if there's something wrong on my side the gets me the error exit code.

Anyway, the issue that I'm hitting is that I'm getting a non-zero return code (1) from fuzzel after exiting the launcher without trying to select an app and launch it.

This creates two problems for me.

1. I'm using systemd-run to run fuzzel and the lauched apps under a different slice, and the the error exit code shows up as a failure in systemd's log.

2. In my sway config, I want to take into account that systemd-run might fail running fuzzel, so I'm adding a fallback to run fuzzel directly like this

bindsym $mod+Shift+d exec --no-startup-id systemd-run --user --slice app.slice --quiet --no-block --collect fuzzel-launch || fuzzel-launch

but due to the error exit code, Sway is launching fuzzel twice.

I'm not sure if this is a bug or a request feature, and I haven't went through the code, and try to understand if there's something wrong on my side the gets me the error exit code. Anyway, the issue that I'm hitting is that I'm getting a non-zero return code (1) from fuzzel after exiting the launcher without trying to select an app and launch it. This creates two problems for me. 1. I'm using systemd-run to run fuzzel and the lauched apps under a different slice, and the the error exit code shows up as a failure in systemd's log. 2. In my sway config, I want to take into account that systemd-run might fail running fuzzel, so I'm adding a fallback to run fuzzel directly like this ``` bindsym $mod+Shift+d exec --no-startup-id systemd-run --user --slice app.slice --quiet --no-block --collect fuzzel-launch || fuzzel-launch ``` but due to the error exit code, Sway is launching fuzzel twice.

dnkl commented 2022年02月04日 21:26:58 +01:00

I believe this was done to be able to tell the difference between something was launched and something was not launched, in scripts.

Can't quite remember however.

In any case, this is probably only useful in dmenu mode. In "normal" mode, it's probably fine to exit with code 0.

I believe this was done to be able to tell the difference between something was launched and something was not launched, in scripts. Can't quite remember however. In any case, this is probably only useful in dmenu mode. In "normal" mode, it's probably fine to exit with code 0.

tinywrkb commented 2022年02月04日 22:32:56 +01:00

It would be great if this would be limited to dmenu mode.

It would be great if this would be limited to dmenu mode.