key-bindings.pipe-* configs produce errors #809

Arnavion commented 2021年11月21日 02:59:20 +01:00

(1.10.0)

With a config that contains just:

[key-bindings]
pipe-scrollback=[/usr/bin/false] none
pipe-selected=[/usr/bin/false] none
pipe-visible=[/usr/bin/false] none

... foot prints:

error: /tmp/foot.ini:2: [ipe-scrollback].pipe-scrollbck: Ma: not a valid XKB key name: Ma
error: /tmp/foot.ini:3: [ipe-selected].pipe-selected: aMa: not a valid XKB key name: aMa

As part of my actual, larger, config, foot prints:

error: /home/arnavion/.config/foot/foot.ini:39: [ipe-scrollback].pipe-scrollback: /Color-schemes: not a valid XKB key name: /Color-schemes
error: /home/arnavion/.config/foot/foot.ini:40: [ipe-selected].pipe-selected: ki/Color-schemes: not a valid XKB key name: ki/Color-schemes
error: /home/arnavion/.config/foot/foot.ini:41: [ipe-visible].pipe-visible: iki/Color-schemes: not a valid XKB key name: iki/Color-schemes

(1.10.0) With a config that contains just: ``` [key-bindings] pipe-scrollback=[/usr/bin/false] none pipe-selected=[/usr/bin/false] none pipe-visible=[/usr/bin/false] none ``` ... foot prints: ``` error: /tmp/foot.ini:2: [ipe-scrollback].pipe-scrollbck: Ma: not a valid XKB key name: Ma error: /tmp/foot.ini:3: [ipe-selected].pipe-selected: aMa: not a valid XKB key name: aMa ``` As part of my actual, larger, config, foot prints: ``` error: /home/arnavion/.config/foot/foot.ini:39: [ipe-scrollback].pipe-scrollback: /Color-schemes: not a valid XKB key name: /Color-schemes error: /home/arnavion/.config/foot/foot.ini:40: [ipe-selected].pipe-selected: ki/Color-schemes: not a valid XKB key name: ki/Color-schemes error: /home/arnavion/.config/foot/foot.ini:41: [ipe-visible].pipe-visible: iki/Color-schemes: not a valid XKB key name: iki/Color-schemes ```

Arnavion commented 2021年11月21日 05:32:32 +01:00

From debugging, pipe_argv_from_value already updated ctx->value to skip past the part enclosed in [], so parse_key_binding_section should not be doing that itself.

From debugging, `pipe_argv_from_value` already updated `ctx->value` to skip past the part enclosed in `[]`, so `parse_key_binding_section` should not be doing that itself.