Tab indentation seems wrong in pipe-view #2194

saeedark commented 2025年10月11日 01:40:19 +02:00

Foot Version

foot version: 1.24.0-13-g371837ef (Oct 11 2025, branch 'masteronn') -pgo +ime -graphemes +assertions

TERM environment variable

foot

Compositor Name and Version

niri

Distribution

ubuntu 24.04

Terminal multiplexer

No response

Shell, TUI, application

fish

Server/standalone mode

• Standalone
• Server

Foot config

-

Description of Bug and Steps to Reproduce

Hi.
Thank you for developing foot again.

Piping the term view with tabs in it may not look exactly like the term view! (please see the picture below)

I have no idea how tabs and tab stops work, but the diff attached seems to make output similar to term view. However, I'm not sure changing tabs into spaces is a good idea or not.

picture:
(left side is a pager, right side: foot)
(foot version is different in the picture, but I have reproduced it in mentioned version.)

Relevant logs, stacktraces, etc.

No response

### Foot Version foot version: 1.24.0-13-g371837ef (Oct 11 2025, branch 'masteronn') -pgo +ime -graphemes +assertions ### TERM environment variable foot ### Compositor Name and Version niri ### Distribution ubuntu 24.04 ### Terminal multiplexer _No response_ ### Shell, TUI, application fish ### Server/standalone mode - [ ] Standalone - [ ] Server ### Foot config ```ini - ``` ### Description of Bug and Steps to Reproduce Hi. Thank you for developing foot again. Piping the term view with tabs in it may not look exactly like the term view! (please see the picture below) I have no idea how tabs and tab stops work, but the diff attached seems to make output similar to term view. However, I'm not sure changing tabs into spaces is a good idea or not. picture: (left side is a pager, right side: foot) (foot version is different in the picture, but I have reproduced it in mentioned version.) ### Relevant logs, stacktraces, etc. _No response_

dnkl commented 2025年10月11日 08:42:30 +02:00

I can't reproduce it here. If you could find a printf "something\t\tsomething else\n" that shows the issue, that would be helpful. I'm not considering any patches until I've understood the problem.

I can't reproduce it here. If you could find a `printf "something\t\tsomething else\n"` that shows the issue, that would be helpful. I'm not considering any patches until I've understood the problem.

dnkl commented 2025年10月11日 08:47:06 +02:00

This appears to reproduce the issue:

printf "f \tbar\nfo \tbar\nfoo \tbar\nfooo \tbar\nfoooo \tbar\nfooooo \tbar\nfoooooo \tbar\n"

It's most likely an off-by one somewhere.

This appears to reproduce the issue: ```sh printf "f \tbar\nfo \tbar\nfoo \tbar\nfooo \tbar\nfoooo \tbar\nfooooo \tbar\nfoooooo \tbar\n" ``` It's most likely an off-by one somewhere.

dnkl commented 2025年10月11日 08:48:23 +02:00

Actually no, it only looked like it reproduced because my editor (which I used do display the pipe output) used a different tab length. cat:ing the temporary file in the terminal looks exactly like the original output.

Actually no, it only looked like it reproduced because my editor (which I used do display the pipe output) used a different tab length. `cat`:ing the temporary file in the terminal looks exactly like the original output.

saeedark commented 2025年10月11日 09:04:57 +02:00

Sorry I'm not an expert in this. Is there a way that I can record my terminal for that example?

Sorry I'm not an expert in this. Is there a way that I can record my terminal for that example?

dnkl commented 2025年10月11日 09:27:27 +02:00

https://asciinema.org/ might work

https://asciinema.org/ might work

saeedark commented 2025年10月11日 09:33:48 +02:00

nope, asciinema turns everything in spaces.

found one:
printf " f \tbar\tfo \t\t \tbar\n foo \tbar \n fooo \tbar\nfoooo \tbar\n fooooo \tbar\n foooooo \tbar \tfoo \t \t bar \n"

the last column "bar" are not align in terminal, but they are in output

nope, asciinema turns everything in spaces. found one: `printf " f \tbar\tfo \t\t \tbar\n foo \tbar \n fooo \tbar\nfoooo \tbar\n fooooo \tbar\n foooooo \tbar \tfoo \t \t bar \n"` the last column "bar" are not align in terminal, but they are in output

dnkl commented 2025年10月11日 10:08:49 +02:00

Thanks, that reproduces here as well :)

In fact, this appears to be enough:

$ printf "\t foo\n0123456701234567\n"

Thanks, that reproduces here as well :) In fact, this appears to be enough: ```sh $ printf "\t foo\n0123456701234567\n" ```

dnkl commented 2025年10月11日 10:10:26 +02:00

Please test #2195

Please test https://codeberg.org/dnkl/foot/pulls/2195

saeedark commented 2025年10月11日 10:20:53 +02:00

Thank you.

Thank you.