The bold-text-in-bright option is not applied correctly to selected text and backgrounds #1836

rozhur commented 2024年09月12日 14:18:10 +02:00

Foot Version

foot version: 1.13.1 +pgo +ime +graphemes -assertions

TERM environment variable

xterm-256color

Compositor Version

sway version 1.7

Description of Bug and Steps to Reproduce

The bold-text-in-bright option does not work correctly for selected text and backgrounds, making the text difficult to read:
2024年09月12日_16-57-42-284.png

I changed the following code in render.c:

there where (https://codeberg.org/dnkl/foot/src/branch/master/render.c#L763)

 if (term->conf->bold_in_bright.enabled && cell->attrs.bold)
 _fg = color_brighten(term, _fg);

I replaced it with

 if (term->conf->bold_in_bright.enabled && cell->attrs.bold) {
 if (cell->attrs.reverse ^ is_selected) {
 _bg = color_brighten(term, _bg);
 } else {
 _fg = color_brighten(term, _fg);
 }
 }

Now:
latest.png

Relevant logs, stacktraces, etc.

No response

### Foot Version foot version: 1.13.1 +pgo +ime +graphemes -assertions ### TERM environment variable xterm-256color ### Compositor Version sway version 1.7 ### Description of Bug and Steps to Reproduce The `bold-text-in-bright` option does not work correctly for selected text and backgrounds, making the text difficult to read:  I changed the following code in `render.c`: there where (https://codeberg.org/dnkl/foot/src/branch/master/render.c#L763) ``` if (term->conf->bold_in_bright.enabled && cell->attrs.bold) _fg = color_brighten(term, _fg); ``` I replaced it with ``` if (term->conf->bold_in_bright.enabled && cell->attrs.bold) { if (cell->attrs.reverse ^ is_selected) { _bg = color_brighten(term, _bg); } else { _fg = color_brighten(term, _fg); } } ``` Now:  ### Relevant logs, stacktraces, etc. _No response_

spaceone commented 2026年01月10日 22:33:44 +01:00

Thanks, very much! I am affected by this as well.

Thanks, very much! I am affected by this as well.