When using nnn file manager, foot will not show a title when nnn is first launched (other terminals do work correctly) #1783

charbelnicolas commented 2024年07月27日 17:03:50 +02:00

Foot Version

foot version: 1.17.2 +pgo +ime +graphemes -assertions

TERM environment variable

foot

Compositor Version

labwc 0.7.3-52-g750d37b1

Description of Bug and Steps to Reproduce

When using nnn file manager, foot will not show a title when nnn is first launched through a shortcut or through the terminal by typing foot nnn -x, foot -e nnn foot nnn or foot -e nnn -x. It is only when one navigates to a different directory that the title will show up. I tried the same with kitty, xterm and alacritty and they all work.

The only way this works is if I open foot first and then just launch nnn in the already open terminal.

Relevant logs, stacktraces, etc.

No response

### Foot Version foot version: 1.17.2 +pgo +ime +graphemes -assertions ### TERM environment variable foot ### Compositor Version labwc 0.7.3-52-g750d37b1 ### Description of Bug and Steps to Reproduce When using `nnn` file manager, foot will not show a title when nnn is first launched through a shortcut or through the terminal by typing `foot nnn -x`, `foot -e nnn` `foot nnn` or `foot -e nnn -x`. It is only when one navigates to a different directory that the title will show up. I tried the same with `kitty`, `xterm` and `alacritty` and they all work. The only way this works is if I open foot first and then just launch `nnn` in the already open terminal. ### Relevant logs, stacktraces, etc. _No response_

dnkl commented 2024年07月27日 17:40:03 +02:00

I'm going to guess a bit here, but I believe the issue is that nnn isn't setting the initial title by itself.

The other terminals are most likely setting the initial title based on the command line. Foot doesn't, it sets the title to whatever you've configured in your foot.ini (defaulting to foot/footclient).

Then, I believe nnn does set the title when you change directory.

The reason it works when you start nnn from within an already running terminal instance is most likely that the shell sets the title.

I'm going to guess a bit here, but I believe the issue is that nnn isn't setting the initial title by itself. The other terminals are most likely setting the initial title based on the command line. Foot doesn't, it sets the title to whatever you've configured in your foot.ini (defaulting to foot/footclient). Then, I believe nnn **does** set the title when you change directory. The reason it works when you start nnn from within an already running terminal instance is most likely that the shell sets the title.

charbelnicolas commented 2024年07月27日 18:07:56 +02:00

nnn does set the initial title by itself, please check the video below:

https://drive.google.com/file/d/1sk_Cll6hVXdp717AlIpoTZqOJuZ4aepb/view?usp=sharing

I actually had a small discussion about it on nnn's github but quickly realized it was foot who was at fault:

https://github.com/jarun/nnn/discussions/1918

nnn does set the initial title by itself, please check the video below: [https://drive.google.com/file/d/1sk_Cll6hVXdp717AlIpoTZqOJuZ4aepb/view?usp=sharing](https://drive.google.com/file/d/1sk_Cll6hVXdp717AlIpoTZqOJuZ4aepb/view?usp=sharing) I actually had a small discussion about it on nnn's github but quickly realized it was foot who was at fault: [https://github.com/jarun/nnn/discussions/1918](https://github.com/jarun/nnn/discussions/1918)

dnkl commented 2024年07月27日 18:24:07 +02:00

Here's the log output from a slightly instrumented foot build:

1360: PUSH TITLE
 err: csi.c:1360: PUSH TITLE
 dbg: osc.c:1293: resized OSC buffer: 4096
 dbg: osc.c:911: OSC: 7;file://mini.la.casa/home/daniel/src/foot/bld/debug (param = 7)
 dbg: osc.c:441: PWD: URI: file://mini.la.casa/home/daniel/src/foot/bld/debug
 dbg: osc.c:450: OSC7: pwd: /home/daniel/src/foot/bld/debug
 dbg: osc.c:911: OSC: 2;~/src/foot/bld/debug (param = 2)
 err: csi.c:1371: POP TITLE
 err: csi.c:1360: PUSH TITLE
 dbg: osc.c:911: OSC: 104 (param = 104)
 dbg: osc.c:1113: resetting all colors
 err: csi.c:1371: POP TITLE
 err: csi.c:1360: PUSH TITLE
 dbg: osc.c:911: OSC: 104 (param = 104)
 dbg: osc.c:1113: resetting all colors

Yes, it sets the title (that's the OSC: 2). But after that it pops the title it saved before changing the title.

Here's the log output from a slightly instrumented foot build: ``` 1360: PUSH TITLE err: csi.c:1360: PUSH TITLE dbg: osc.c:1293: resized OSC buffer: 4096 dbg: osc.c:911: OSC: 7;file://mini.la.casa/home/daniel/src/foot/bld/debug (param = 7) dbg: osc.c:441: PWD: URI: file://mini.la.casa/home/daniel/src/foot/bld/debug dbg: osc.c:450: OSC7: pwd: /home/daniel/src/foot/bld/debug dbg: osc.c:911: OSC: 2;~/src/foot/bld/debug (param = 2) err: csi.c:1371: POP TITLE err: csi.c:1360: PUSH TITLE dbg: osc.c:911: OSC: 104 (param = 104) dbg: osc.c:1113: resetting all colors err: csi.c:1371: POP TITLE err: csi.c:1360: PUSH TITLE dbg: osc.c:911: OSC: 104 (param = 104) dbg: osc.c:1113: resetting all colors ``` Yes, it sets the title (that's the OSC: 2). But **after** that it pops the title it saved **before** changing the title.

dnkl commented 2024年07月27日 18:28:23 +02:00

Trying XTerm, the title is set to nnn, not a directory. As I explained before, that's the terminal that sets the title based on the command line; foot doesn't it sets the title to what you've configured in foot.ini. If you want a workaround for this, see: https://codeberg.org/dnkl/foot/wiki#foot-e-cmd-does-not-set-the-window-title-to-cmd

Trying XTerm, the title is set to `nnn`, not a directory. As I explained before, that's the terminal that sets the title based on the command line; foot doesn't it sets the title to what you've configured in foot.ini. If you want a workaround for this, see: https://codeberg.org/dnkl/foot/wiki#foot-e-cmd-does-not-set-the-window-title-to-cmd

charbelnicolas commented 2024年07月27日 18:59:44 +02:00

Did you at least watch the video? How come every other terminal in wayland and x11 show the initial folder as a the title correctly but foot doesn't?

If you don't want to fix it that's fine but to me this looks like a bug.

Did you at least watch the video? How come every other terminal in wayland and x11 show the initial folder as a the title correctly but foot doesn't? If you don't want to fix it that's fine but to me this looks like a bug.

dnkl commented 2024年07月27日 19:01:38 +02:00

When I tested Xterm it did not show the directory as title, it showed nnn. As I wrote in my previous reply.

Other terminals probably don't implement the title push/pop escapes.

When I tested Xterm it did **not** show the directory as title, it showed nnn. As I wrote in my previous reply. Other terminals probably don't implement the title push/pop escapes.

charbelnicolas commented 2024年07月27日 19:09:25 +02:00

When I tested Xterm it did not show the directory as title, it showed nnn. As I wrote in my previous reply.

Other terminals probably don't implement the title push/pop escapes.

That's because you did not use the -x flag.

xterm -e nnn -x

> When I tested Xterm it did **not** show the directory as title, it showed nnn. As I wrote in my previous reply. > > Other terminals probably don't implement the title push/pop escapes. That's because you did not use the -x flag. `xterm -e nnn -x`

charbelnicolas commented 2024年07月27日 19:14:14 +02:00

And I assume you didn't watch the video based on your response, sigh.

And I assume you didn't watch the video based on your response, sigh.

dnkl commented 2024年07月27日 19:16:56 +02:00

I ran xterm -e nnn -x. Just as I used -x when testing in foot. That's why you see the osc-2 in the log output.

Xterm still sets the title to nnn. I guess you have a different xterm than I do.

I'm done here. The sequence of escapes sent by nnn are clear; the title is saved, then set to a directory, then popped. There's nothing to fix.

I ran `xterm -e nnn -x`. Just as I used -x when testing in foot. That's why you see the osc-2 in the log output. Xterm still sets the title to nnn. I guess you have a different xterm than I do. I'm done here. The sequence of escapes sent by nnn are clear; the title is saved, then set to a directory, then popped. There's nothing to fix.

dnkl commented 2024年07月27日 19:21:47 +02:00

Hint: terminfo matters. Some terminfos have capabilities that contain escapes to push/pop the title.

Maybe nnn are emitting those.

Hint: terminfo matters. Some terminfos have capabilities that contain escapes to push/pop the title. Maybe nnn are emitting those.

NRK commented 2024年07月28日 00:20:31 +02:00

But after that it pops the title it saved before changing the title.

Interesting... Thanks for the log. nnn codebase is a bit hard to get around but from some cursory grepping, only places where we explicitly emit these are at init (line ~9001):

	if (cfg.x11 && !g_state.picker) {
		/* Save terminal window title */
		printf("033円[22;0t");

During the main loop (xterm_cfg(), line ~1390):

		printf("033円]2;%s007円", r ? &path[homelen - 1] : path);

And at exit (cleanup(), line ~8532):

	if (cfg.x11 && !g_state.picker) {
		printf("033円[23;0t"); /* reset terminal window title */

I don't see where the pop request is coming from, it should only occur at exit. Maybe it's being emitted indirectly (through ncurses?). I'll try to investigate it a bit more later and figure out what's going on.

> But after that it pops the title it saved before changing the title. Interesting... Thanks for the log. `nnn` codebase is a bit hard to get around but from some cursory grepping, only places where we *explicitly* emit these are at init (line ~9001): ```c if (cfg.x11 && !g_state.picker) { /* Save terminal window title */ printf("033円[22;0t"); ``` During the main loop (`xterm_cfg()`, line ~1390): ```c printf("033円]2;%s007円", r ? &path[homelen - 1] : path); ``` And at exit (`cleanup()`, line ~8532): ```c if (cfg.x11 && !g_state.picker) { printf("033円[23;0t"); /* reset terminal window title */ ``` I don't see where the pop request is coming from, it should only occur at exit. Maybe it's being emitted indirectly (through `ncurses`?). I'll try to investigate it a bit more later and figure out what's going on.