12
167
Fork
You've already forked fnott
32

[feature-request] add config-option max-notifications (spawning notifications until no more space crashes river) #61

Open
opened 2022年03月27日 15:39:53 +02:00 by rosch · 1 comment

me again :)

this is most likely a river only bug, as the window manager is responsible for handling surfaces & the screen.
i want to just inform you about this issue.

https://github.com/riverwm/river/issues/574

if you set the anchor=bottom-right in fnott.ini, new notifications will stack up from the bottom to the top.
when there is no more space for the next notification, river will crash panic with integer overflow.

what i wanted to ask you.. how much work would it require to add a config option like max-notifications to display only a certain number of notifications ?

mako is doing it in a clever way to display notifications until max is reached, then adds a notification below with the count of additional notifications eg: (4 more). clicking notifications loops through all remaining ones & displays them.

see:

me again :) this is most likely a river only bug, as the window manager is responsible for handling surfaces & the screen. i want to just inform you about this issue. [https://github.com/riverwm/river/issues/574](https://github.com/riverwm/river/issues/574) if you set the `anchor=bottom-right` in fnott.ini, new notifications will stack up from the bottom to the top. when there is no more space for the next notification, river will crash panic with integer overflow. **what i wanted to ask you..** how much work would it require to add a config option like `max-notifications` to display only a certain number of notifications ? mako is doing it in a clever way to display notifications until max is reached, then adds a notification below with the count of additional notifications eg: `(4 more)`. clicking notifications loops through all remaining ones & displays them. see: ![](https://0x0.st/oqbG.gif)
Owner
Copy link

Yeah, I think adding this makes sense

Yeah, I think adding this makes sense
Sign in to join this conversation.
No Branch/Tag specified
master
releases/1.8
releases/1.7
releases/1.6
releases/1.5
release/1.4
parse-font-apply-fontconfig-rules
releases/1.3
releases/1.2
releases/1.1
releases/1.0
1.8.0
1.7.1
1.7.0
1.6.0
1.5.0
1.4.1
1.4.0
1.3.0
1.2.1
1.2.0
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.0.0
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/fnott#61
Reference in a new issue
dnkl/fnott
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?