Html entities #135

tr147 commented 2024年10月25日 19:02:16 +02:00

Notifications from Claws Mail keep the <and >. Shouldn't decode_html_entities replace them with < and >?

I'm using fnott v1.7.0 on FreeBSD.

Notifications from Claws Mail keep the `&lt;`and `&gt;`. Shouldn't decode_html_entities replace them with < and >? I'm using fnott v1.7.0 on FreeBSD.

tr147 commented 2024年11月03日 08:32:08 +01:00

It seems, that fnott uses obsolete ("basic") regular expressions, but then is '|' an ordinary character and there is no equivalent for its functionality.

When i compiled regular expression as modern ("extended") RE, then decode_html_entities started to work:

int r = regcomp(
 &mgr->html_entity_re,
 /* Entity names (there's a *lot* of these - we only support the common ones */
 "&(nbsp|lt|gt|amp|quot|apos|cent|pound|yen|euro|copy|reg);|"
 /* Decimal entity number: ' */
 "&#([0-9]+);|"
 /* Hexadecimal entity number: ' */
 "&#x([0-9a-fA-F]+);", REG_EXTENDED);

It seems, that fnott uses obsolete ("basic") regular expressions, but then is `'|'` an ordinary character and there is no equivalent for its functionality. When i compiled regular expression as modern ("extended") RE, then `decode_html_entities` started to work: ``` int r = regcomp( &mgr->html_entity_re, /* Entity names (there's a *lot* of these - we only support the common ones */ "&(nbsp|lt|gt|amp|quot|apos|cent|pound|yen|euro|copy|reg);|" /* Decimal entity number: &#39; */ "&#([0-9]+);|" /* Hexadecimal entity number: &#x27; */ "&#x([0-9a-fA-F]+);", REG_EXTENDED); ```

dnkl commented 2025年11月12日 14:16:45 +01:00

We can switch to an extended expression. The current one works just fine on Linux, so there must be some different in the regex implementations in glibc and FreeBSD's libc.

We can switch to an extended expression. The current one works just fine on Linux, so there must be some different in the regex implementations in glibc and FreeBSD's libc.