example: split fcft-specific parts from wayland boilerplate (and perhaps add fractional scaling) #76

runxiyu commented 2025年02月25日 03:49:16 +01:00

Currently, the example program does not support fractional scaling (or scaling at all incl. integer scaling). This causes the output to look blurry when the compositor is used to use a non-1.

Could it be made to support fractional scaling? (especially since text rendering is a place where artificial scaling by the compositor is very undesirable)

Currently, the example program does not support fractional scaling (or scaling at all incl. integer scaling). This causes the output to look blurry when the compositor is used to use a non-1. Could it be made to support fractional scaling? (especially since text rendering is a place where artificial scaling by the compositor is very undesirable)

dnkl commented 2025年02月25日 07:53:29 +01:00

I'd rather not do that; the example is meant to show how to use fcft, not how to program wayland. Adding fractional scaling support would add a lot of wayland boiler plate code, which would clutter the example.

This is especially true since fcft itself isn't wayland only. I.e. getting the scaling value is platform dependent, and hasn't anything to do with fcft.

Once you have a scaling value, all you need to do is instantiate another fcft font, with it's :size property multipled by the scaling factor.

Still, I'll leave this issue open for the time being. Perhaps the example can be split up into more source files, with all the wayland logic removed from the main code.

I'd rather not do that; the example is meant to show how to use fcft, not how to program wayland. Adding fractional scaling support would add a lot of wayland boiler plate code, which would clutter the example. This is especially true since fcft itself isn't wayland only. I.e. getting the scaling value is platform dependent, and hasn't anything to do with fcft. Once you have a scaling value, all you need to do is instantiate another fcft font, with it's `:size` property multipled by the scaling factor. Still, I'll leave this issue open for the time being. Perhaps the example can be split up into more source files, with all the wayland logic removed from the main code.

runxiyu commented 2025年02月25日 09:25:48 +01:00

That makes sense, thanks for the clarification

That makes sense, thanks for the clarification