There is a check for the locale in 'base_pattern_from_name'. The 'CHANGES.md' mentions the cause of not setting/restoring is thread safety of setlocale. Just wondering can this not be fixed by using the threadsafe 'uselocale' on linux and mac?
The 'CHANGES.md' file mentions that the user should set it. At the vary least the thread safety aspect and proper use should be mentioned in the manpage of 'fcft_from_name'.
Especially since he use of harfbuzz will be more international audience, proper use of setting/restoring the locale should be shown in the example code of the 'fcft_from_name' manpage and the 'example/main.c' code, this to prevent the code only working in English-speaking countries and then suddenly strange errors elsewhere in the world, also considering the guarding 'assert' might disappear with -DNDEBUG.
There is a check for the locale in 'base_pattern_from_name'. The 'CHANGES.md' mentions the cause of not setting/restoring is thread safety of setlocale. Just wondering can this not be fixed by using the threadsafe 'uselocale' on linux and mac?
The 'CHANGES.md' file mentions that the user should set it. At the vary least the thread safety aspect and proper use should be mentioned in the manpage of 'fcft_from_name'.
Especially since he use of harfbuzz will be more international audience, proper use of setting/restoring the locale should be shown in the example code of the 'fcft_from_name' manpage and the 'example/main.c' code, this to prevent the code only working in English-speaking countries and then suddenly strange errors elsewhere in the world, also considering the guarding 'assert' might disappear with -DNDEBUG.