Same as #760
[strings] Support Weblate for cuisines search categories #2175
x7z4w-cuisine into main This will conflict with #2172 and also it probably would be good to have a way to keep the commented out terms
Also this reminds me that it has become difficult to edit the categories since the change to JSON files (despite the obvious translation benefits). I think we need to find a way to edit them together for all languages easier.
Maybe a solution would be to also have a (manual invoked) script to convert the categories.txt file back to the localize.json files? This way it would be possible to easily do changes in the generated text file and then have them converted back to the JSON files for better translation.
@yannikbloscheck wrote in #2175 (comment):
This will conflict with #2172
I'll rebase once it's merged.
have a way to keep the commented out terms
Not sure why do we need them? They don't have translations.
@yannikbloscheck wrote in #2175 (comment):
Also this reminds me that it has become difficult to edit the categories since the change to JSON files (despite the obvious translation benefits). I think we need to find a way to edit them together for all languages easier. Maybe a solution would be to also have a (manual invoked) script to convert the
categories.txtfile back to thelocalize.jsonfiles? This way it would be possible to easily do changes in the generated text file and then have them converted back to the JSON files for better translation.
You can convert it back, but I don't know if the order of values remains the same in JSON (to prevent huge diffs).
UPD: the order is not the same. Still, I'm not sure why is it difficult for you, unless someone would want to add all languages at the same time, it's easy as it was before.
39f2c62375
3364924816
@x7z4w wrote in #2175 (comment):
Not sure why do we need them? They don't have translations.
Not the new ones I added in the pull request, but the commented out that already are in there. Also if the commented out ones weren't in there, I wouldn't have known not to include some of them for now.
You can convert it back, but I don't know if the order of values remains the same in JSON (to prevent huge diffs).
I think it would be really good to actually include the script in our repo, because I think we will probably need it again.
3364924816
971a64cbe2
The decision was made to move them to the regular category files instead. So switching this to WIP in the meantime to prevent accidental merges.
971a64cbe2
964ee0aa3b
Tested working.
@comaps/iOS need to delete categories_cuisines.txt from XCode
964ee0aa3b
5bb90ede66
Removed the file. This seems to work on the place page and editor, but the search categories like "Where to eat", "Hotel" etc. now seem to be broken.
5bb90ede66
4833433830
4833433830
7e1ca94163
Making it work by using more of the same logic as the normal parts. Needs a regenerated map though for the cuisines to become searchable again.
7e1ca94163
9949992c4b
Works now for me (with a newly generated map)
Merge it @x7z4w?
(Can't ask you to review it in the interface, because it is your pull request)
Ready to merge except the nit below
@ -311,0 +314,4 @@
"cuisine-pancake|cuisine-crepe": "Бліны|панкейкі",
"cuisine-seafood|cuisine-fish": "Морапрадукты|рыба|рыбны",
"@cuisine_all_vegetarian": "Вегетарыянская кухня",
"cuisine-vegan|@cuisine_all_vegetarian": "Веганская кухня|Вегетарыянская кухня"
It would be great to have this deduplicated (@cuisine_all_vegetarian term is repeated)
Deduplicated it for all languages
9949992c4b
bc67f856fd
bc67f856fd
d177661c05
A fix for failing Android builds: #3724
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?