5
0
Fork
You've already forked python-calendarweek
0

Inconsistent return value/type #8

Open
opened 2023年01月02日 16:02:12 +01:00 by magicfelix · 0 comments
magicfelix commented 2023年01月02日 16:02:12 +01:00 (Migrated from edugit.org)
Copy link

While from_date, get_last_week_of_year and weeks_within return a (Sequence of) CalendarWeek, current_week returns an int.

My proposal is to also let current_week also return a CalendarWeek. That way, the week number (which is currently returned), can still be accessed very easily (using .week), and the information is more complete.

This would probably require a major version jump, because it's a breaking change.

While `from_date`, `get_last_week_of_year` and `weeks_within` return a (`Sequence` of) `CalendarWeek`, `current_week` returns an `int`. My proposal is to also let `current_week` also return a `CalendarWeek`. That way, the week number (which is currently returned), can still be accessed very easily (using `.week`), and the information is more complete. This would probably require a major version jump, because it's a breaking change.
Sign in to join this conversation.
No Branch/Tag specified
master
renovate/django-6.x
0.5.3
0.5.2
0.5.1
0.5.0
0.4.7
0.4.6.post2
0.4.6.post1
0.4.6
0.4.5
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.3.1
0.3.0
0.2.1
0.2.0
0.1.1
0.1.0.post0
0.1.0
Labels
Clear labels
part
backend
 Backend (view code, models, logic, etc.)
part
ci
part
docs
 Issue or addition to the documentation
part
frontend
 Frontend (templates, etc.)
part
i18n
 Translation or internationalisation issue
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion
part
packaging
 Issue concerning the packaging of AlekSIS and components
prio
1
 Priority High
prio
2
 Priority Medium
prio
3
 Priority Low
release-mr-5.x
Security
size
large
size
medium
size
small
source
customer
 Requested by a customer or affiliated user
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it
TeX
Needs LaTeX template
type
bug
 Bug
type
feature
 New feature
type
refactoring
workflow
blocked
 Issue is blocked by another issue
workflow
confirmed
 The bug is reproducible and will be fixed
workflow
current-todo
workflow
discussing
 Needs to be discussed before implementation
workflow
new-app
 Requires new AlekSIS app, which has to be created
workflow
wontfix
 The bug is not reproducible or the feature was decided against
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
collab-maint/python-calendarweek#8
Reference in a new issue
collab-maint/python-calendarweek
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?