bug: not possible to redact annotations in some files #137

mahlzahn commented 2026年03月12日 16:46:59 +01:00

Description

!136 implemented redaction of annotations, but it fails on the sample PDF file from https://github.com/py-pdf/sample-files/tree/main/024-annotations because of an AttributeError:

/usr/lib/python3.14/site-packages/pymupdf/__init__.py in ?(self, name, xref)
 10219 if xref == 0:
 10220 annot = JM_get_annot_by_name(page, name)
 10221 else:
 10222 annot = JM_get_annot_by_xref(page, xref)
> 10223 if annot.m_internal:
 10224 return Annot(annot)
AttributeError: 'NoneType' object has no attribute 'm_internal'

Related upstream issue

https://github.com/pymupdf/PyMuPDF/issues/4928

## Description !136 implemented redaction of annotations, but it fails on the sample PDF file from https://github.com/py-pdf/sample-files/tree/main/024-annotations because of an `AttributeError`: ```py /usr/lib/python3.14/site-packages/pymupdf/__init__.py in ?(self, name, xref) 10219 if xref == 0: 10220 annot = JM_get_annot_by_name(page, name) 10221 else: 10222 annot = JM_get_annot_by_xref(page, xref) > 10223 if annot.m_internal: 10224 return Annot(annot) AttributeError: 'NoneType' object has no attribute 'm_internal' ``` ## Related upstream issue https://github.com/pymupdf/PyMuPDF/issues/4928

mahlzahn commented 2026年03月16日 14:39:23 +01:00

With v0.5.0, the impact of this issue is low, because:

1. The user is warned about it with an alert dialog
2. On pages, where annotation redaction fails, all annotations are removed during the final sanitization step when the document is saved.

With [v0.5.0](https://codeberg.org/censor/Censor/releases/tag/v0.5.0), the impact of this issue is low, because: 1. The user is warned about it with an alert dialog 2. On pages, where annotation redaction fails, all annotations are removed during the final sanitization step when the document is saved.