2
1
Fork
You've already forked hacks
5

notify not working since v23.02.1 #2

Closed
opened 2023年03月20日 15:46:19 +01:00 by rseffner · 1 comment
rseffner commented 2023年03月20日 15:46:19 +01:00 (Migrated from github.com)
Copy link

Changelog says : "Logical Theme System Event Change"
I see "Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function(string $type, $detail)" is not triggered anymore since Update.

Do we need some code changes?

Changelog says : "Logical Theme System Event Change" I see "Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function(string $type, $detail)" is not triggered anymore since Update. Do we need some code changes?
ssddanbrown commented 2023年03月22日 12:07:08 +01:00 (Migrated from github.com)
Copy link

Tested the following on v23.02.1:

<?php
use BookStack\Facades\Theme;
use BookStack\Theming\ThemeEvents;
Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function (string $type, $detail) {
 Log::info(json_encode([$type, $detail]));
});

Event ran as expected.
As mentioned in the readme and on the hacks site, I do not provide support for hacks so I'm going to close this off.
If you find some changes in the hack, or BookStack, that need to be made for more recent version support feel free to open a PR.

Tested the following on v23.02.1: ```php <?php use BookStack\Facades\Theme; use BookStack\Theming\ThemeEvents; Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function (string $type, $detail) { Log::info(json_encode([$type, $detail])); }); ``` Event ran as expected. As mentioned in the readme and on the hacks site, I do not provide support for hacks so I'm going to close this off. If you find some changes in the hack, or BookStack, that need to be made for more recent version support feel free to open a PR.
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bookstack/hacks#2
Reference in a new issue
bookstack/hacks
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?