notify not working since v23.02.1 #2

rseffner commented 2023年03月20日 15:46:19 +01:00 (Migrated from github.com)

Changelog says : "Logical Theme System Event Change"
I see "Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function(string $type, $detail)" is not triggered anymore since Update.

Do we need some code changes?

Changelog says : "Logical Theme System Event Change" I see "Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function(string $type, $detail)" is not triggered anymore since Update. Do we need some code changes?

ssddanbrown commented 2023年03月22日 12:07:08 +01:00 (Migrated from github.com)

Tested the following on v23.02.1:

<?php
use BookStack\Facades\Theme;
use BookStack\Theming\ThemeEvents;
Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function (string $type, $detail) {
 Log::info(json_encode([$type, $detail]));
});

Event ran as expected.
As mentioned in the readme and on the hacks site, I do not provide support for hacks so I'm going to close this off.
If you find some changes in the hack, or BookStack, that need to be made for more recent version support feel free to open a PR.

Tested the following on v23.02.1: ```php <?php use BookStack\Facades\Theme; use BookStack\Theming\ThemeEvents; Theme::listen(ThemeEvents::ACTIVITY_LOGGED, function (string $type, $detail) { Log::info(json_encode([$type, $detail])); }); ``` Event ran as expected. As mentioned in the readme and on the hacks site, I do not provide support for hacks so I'm going to close this off. If you find some changes in the hack, or BookStack, that need to be made for more recent version support feel free to open a PR.