5
3
Fork
You've already forked bmputil
2

Tests are failing to build #59

Closed
opened 2025年08月18日 13:16:07 +02:00 by perigoso · 2 comments
perigoso commented 2025年08月18日 13:16:07 +02:00 (Migrated from github.com)
Copy link

Tests are failing to compile with the latest upstream and release v1.0.0

Noticed the issue while updating the ArchLinux AUR packages, it happens on both the latest upstream with unlocked cargo fetch and with the release sources with cargo fetch --locked, compiled with cargo build --frozen --release --all-features, and tests run with cargo test --frozen --all-features.

running 2 tests
test src/error.rs - error::ErrorKind::error (line 51) ... FAILED
test src/error.rs - error::ErrorKind::error_from (line 63) ... FAILED
failures:
---- src/error.rs - error::ErrorKind::error (line 51) stdout ----
error[E0433]: failed to resolve: use of undeclared type `ErrorKind`
 --> src/error.rs:52:12
 |
3 | return Err(ErrorKind::DeviceNotFound.error());
 | ^^^^^^^^^ use of undeclared type `ErrorKind`
 |
help: consider importing one of these enums
 |
2 + use std::io::ErrorKind;
 |
2 + use bmputil::error::ErrorKind;
 |
2 + use clap::error::ErrorKind;
 |
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0433`.
Couldn't compile the test.
---- src/error.rs - error::ErrorKind::error_from (line 63) stdout ----
error[E0433]: failed to resolve: use of undeclared type `ErrorKind`
 --> src/error.rs:65:25
 |
4 | operation().map_err(|e| ErrorKind::DeviceNotFound.error_from(e))?;
 | ^^^^^^^^^ use of undeclared type `ErrorKind`
 |
help: consider importing one of these enums
 |
2 + use std::io::ErrorKind;
 |
2 + use bmputil::error::ErrorKind;
 |
2 + use clap::error::ErrorKind;
 |
error[E0599]: no method named `map_err` found for struct `futures_io::Error` in the current scope
 --> src/error.rs:65:13
 |
4 | operation().map_err(|e| ErrorKind::DeviceNotFound.error_from(e))?;
 | ^^^^^^^ method not found in `futures_io::Error`
error: aborting due to 2 previous errors
Some errors have detailed explanations: E0433, E0599.
For more information about an error, try `rustc --explain E0433`.
Couldn't compile the test.
failures:
 src/error.rs - error::ErrorKind::error (line 51)
 src/error.rs - error::ErrorKind::error_from (line 63)
test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s
error: doctest failed, to rerun pass `--doc`
Tests are failing to compile with the latest upstream and release v1.0.0 Noticed the issue while updating the ArchLinux AUR packages, it happens on both the latest upstream with unlocked `cargo fetch` and with the release sources with `cargo fetch --locked`, compiled with `cargo build --frozen --release --all-features`, and tests run with `cargo test --frozen --all-features`. ``` running 2 tests test src/error.rs - error::ErrorKind::error (line 51) ... FAILED test src/error.rs - error::ErrorKind::error_from (line 63) ... FAILED failures: ---- src/error.rs - error::ErrorKind::error (line 51) stdout ---- error[E0433]: failed to resolve: use of undeclared type `ErrorKind` --> src/error.rs:52:12 | 3 | return Err(ErrorKind::DeviceNotFound.error()); | ^^^^^^^^^ use of undeclared type `ErrorKind` | help: consider importing one of these enums | 2 + use std::io::ErrorKind; | 2 + use bmputil::error::ErrorKind; | 2 + use clap::error::ErrorKind; | error: aborting due to 1 previous error For more information about this error, try `rustc --explain E0433`. Couldn't compile the test. ---- src/error.rs - error::ErrorKind::error_from (line 63) stdout ---- error[E0433]: failed to resolve: use of undeclared type `ErrorKind` --> src/error.rs:65:25 | 4 | operation().map_err(|e| ErrorKind::DeviceNotFound.error_from(e))?; | ^^^^^^^^^ use of undeclared type `ErrorKind` | help: consider importing one of these enums | 2 + use std::io::ErrorKind; | 2 + use bmputil::error::ErrorKind; | 2 + use clap::error::ErrorKind; | error[E0599]: no method named `map_err` found for struct `futures_io::Error` in the current scope --> src/error.rs:65:13 | 4 | operation().map_err(|e| ErrorKind::DeviceNotFound.error_from(e))?; | ^^^^^^^ method not found in `futures_io::Error` error: aborting due to 2 previous errors Some errors have detailed explanations: E0433, E0599. For more information about an error, try `rustc --explain E0433`. Couldn't compile the test. failures: src/error.rs - error::ErrorKind::error (line 51) src/error.rs - error::ErrorKind::error_from (line 63) test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s error: doctest failed, to rerun pass `--doc` ```

There are some comments in error.rs it looks like that are being interpreted as tests, and thus the failures.. the comment texts need reviewing to fix this.

There are some comments in error.rs it looks like that are being interpreted as tests, and thus the failures.. the comment texts need reviewing to fix this.

This was fixed in b6a868326c which is part of the v1.1.0 release, so closing this as fixed.

This was fixed in b6a868326c which is part of the v1.1.0 release, so closing this as fixed.
Sign in to join this conversation.
No Branch/Tag specified
main
add-coc-no-ai
v1.1.0
v1.0.0
v1.0.0-rc.2
v1.0.0-rc.1
v0.1.3
v0.1.2
v0.1.1
v0.1.0
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/bmputil#59
Reference in a new issue
blackmagic-debug/bmputil
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?