Add support for STM32H7R/Sxx parts #2170

emeb commented 2025年12月13日 00:36:09 +01:00 (Migrated from github.com)

Detailed description

This change adds new support for the STM32H7R/S family of parts. Although these parts are STM32H7, there are
some differences in the IDs, number of banks and sector sizes as well as the register addresses and bit layouts that make supporting them with the current STM32H7 driver more complex than simply adding a separate driver so that's the approach taken here.

This change is co-authored by zyp who did the initial work. I've updated it for the latest API, made some cleanups
and got a few small details working that had been commented out. Thanks also to dragonmux and ALTracer for invaluable help in coming up to speed on the details.

Your checklist for this pull request

• I've read the Code of Conduct
• I've read the guidelines for contributing to this repository
• It builds for hardware native (see Building the firmware)
• It builds as BMDA (see Building the BMDA)
• I've tested it to the best of my ability
• My commit messages provide a useful short description of what the commits do

Closing issues

Fixes #2170

## Detailed description This change adds new support for the STM32H7R/S family of parts. Although these parts are STM32H7, there are some differences in the IDs, number of banks and sector sizes as well as the register addresses and bit layouts that make supporting them with the current STM32H7 driver more complex than simply adding a separate driver so that's the approach taken here. This change is co-authored by zyp who did the initial work. I've updated it for the latest API, made some cleanups and got a few small details working that had been commented out. Thanks also to dragonmux and ALTracer for invaluable help in coming up to speed on the details. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues Fixes #2170

emeb commented 2025年12月13日 00:44:09 +01:00 (Migrated from github.com)

Looks like 3 CI failures - two are ROM overflows, but I'm guessing the 'pre-commit' is about code formatting?

Looks like 3 CI failures - two are ROM overflows, but I'm guessing the 'pre-commit' is about code formatting?

dragonmux commented 2025年12月13日 00:47:46 +01:00

Correct - lint / pre-commit is shouting about clang-format things. Please also note the contribution guideline about commit suffixing - in this case, mostly stm32h7rs: .

Correct - `lint / pre-commit` is shouting about clang-format things. Please also note the contribution guideline about commit suffixing - in this case, mostly `stm32h7rs: `.

emeb commented 2025年12月13日 03:44:31 +01:00 (Migrated from github.com)

I've corrected the formatting problems and revised the commit messages to include the new target name. The CI failures currently appear to fall into two categories: 1) ROM overflows, and 2) Some sort of mingw CI problem unrelated to my sources.

I've corrected the formatting problems and revised the commit messages to include the new target name. The CI failures currently appear to fall into two categories: 1) ROM overflows, and 2) Some sort of mingw CI problem unrelated to my sources.

emeb commented 2026年04月18日 23:24:04 +02:00

I've made the (c) change as requested but I'm a bit confused about the stm32h7_cmd_psize() change as I don't see any difference between that function in stm32h7rs.c and the equivalent in stm32h7.c - where are the simplifications you mentioned? Perhaps in some other branch?

I've made the (c) change as requested but I'm a bit confused about the stm32h7_cmd_psize() change as I don't see any difference between that function in stm32h7rs.c and the equivalent in stm32h7.c - where are the simplifications you mentioned? Perhaps in some other branch?

dragonmux commented 2026年04月19日 04:54:51 +02:00

Ah! It was in stm32f4.c we did the simplification - see ab3a6e63a8

stm32h7.c also needs this applying, but that can be a separate PR. That commit still shows what we're asking for here.

Ah! It was in stm32f4.c we did the simplification - see ab3a6e63a8f28b6b2191a77f727cd305b9202413 stm32h7.c also needs this applying, but that can be a separate PR. That commit still shows what we're asking for here.

emeb commented 2026年04月26日 23:31:17 +02:00

OK - the copyright change and psize logic simplifications as in stm32f4.c have been added to the stm32h7rs.c file and checked in to my github repo. The firmware works fine for loading code on my own STM32H7RS hardware using a V2.3b BMP.

OK - the copyright change and psize logic simplifications as in stm32f4.c have been added to the stm32h7rs.c file and checked in to my github repo. The firmware works fine for loading code on my own STM32H7RS hardware using a V2.3b BMP.