Feature: flashstub for RP2040 Flashing #1609

vesim987 commented 2023年08月23日 22:22:25 +02:00 (Migrated from github.com)

Detailed description

This PR addresses the Flash write speed problem on the RP2040 by moving a pile of the logic into a RAM stub executed on device. With this PR the speed via BMDA over BMP goes from 220B/s to 1KB/s in the first generation of stub (0a1a384), and then all the way to 12KB/s in the second and final generation of the stub.

Your checklist for this pull request

• I've read the Code of Conduct
• I've read the guidelines for contributing to this repository
• It builds for hardware native (make PROBE_HOST=native)
• It builds as BMDA (make PROBE_HOST=hosted)
• I've tested it to the best of my ability
• My commit messages provide a useful short description of what the commits do

Closing issues

## Detailed description This PR addresses the Flash write speed problem on the RP2040 by moving a pile of the logic into a RAM stub executed on device. With this PR the speed via BMDA over BMP goes from 220B/s to 1KB/s in the first generation of stub (0a1a384), and then all the way to 12KB/s in the second and final generation of the stub. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (`make PROBE_HOST=native`) * [x] It builds as BMDA (`make PROBE_HOST=hosted`) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues <!-- put "fixes #XXXX" here to auto-close the issue(s) that your PR fixes (if any). -->

dragonmux commented 2023年11月16日 02:06:20 +01:00

Of the approaches here and in #1611, we think this one shows the most promise. If it's ok with you, we'd like to pick this up and sort out the lint issues, update the branch and try and get this to a completion point where we can benchmark it and potentially then merge it. Please let us know if this is ok with you?

Of the approaches here and in #1611, we think this one shows the most promise. If it's ok with you, we'd like to pick this up and sort out the lint issues, update the branch and try and get this to a completion point where we can benchmark it and potentially then merge it. Please let us know if this is ok with you?

dragonmux commented 2023年12月16日 09:54:41 +01:00

Given your lack of answer for the last month, we're going to assume this is notionally ok with you and press on in the next week or two. Please let us know if you have any objections to this.

Given your lack of answer for the last month, we're going to assume this is notionally ok with you and press on in the next week or two. Please let us know if you have any objections to this.