7
31
Fork
You've already forked blackmagic
23

Fix: blackpillv2 pinout #1465

Merged
lenvm merged 5 commits from fix/blackpillv2-pinout into main 2023年04月22日 22:01:14 +02:00
lenvm commented 2023年04月22日 14:26:12 +02:00 (Migrated from github.com)
Copy link

Detailed description

This pull request changes the pinout of the blackpillv2 platform.

The changes are done as described in the comments of #1418.

Table 1: comparing current pinout to proposed pinout

function current (e490465) proposal
nRst PB4 PA5
nTRST PB5 (optional) PA6 (optional)
TDI PA1 (also used by LED UART) PB6
TDO PB3 PB7
TCK PA14 PB8
TMS PA13 PB9
PWR PB8 PA1
UART TX PB6 PA2
UART RX PB7 PA3
LED UART PA1 (also used by TDI) PA4
LED idle run PC13 PC13
LED error PC14 PC14
LED boot loader PC15 PC15
USER KEY PA0 PA0
USB VBUS PA9 PA9
USB ID PA10 PA10
USB D- PA11 PA11
USB D+ PA12 PA12
JTAG TMS - PA13
JTAG TCK - PA14
JTAG TDI PA15 PA15
JTAG TDO - PB3
JTAG TRST - PB4

Blackpillv2_pinout_proposal2
Figure 1: proposed pinout

Benefits:

  • This pull request fixes the issue described in #1418. Therefore the is no pin conflict anymore between LED UART and TDI.
  • JTAG pins (PA13, PA14, PA15, PB3, PB4) are not used, such that these pins stay available to program and debug the board.
  • Pins of the STM32F411Cx that are 5V-intolerant (PB5) are not used, to reduce susceptibility to damage.
  • Pins of similar type are located closer to each other on the board.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds for hardware blackpillv2 (make PROBE_HOST=blackpillv2)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability: the code compiles, can be flashed and runs on a board with STM32F401CC microcontroller.
  • My commit messages provide a useful short description of what the commits do

Closing issues

<!-- Filling this template is mandatory --> ## Detailed description <!-- Explain the **details** for making this change. * Is a new feature implemented? * What existing problem(s) does the pull request solve? * How does the pull request solve these problems? Please provide enough information so that others can review your pull request. Information embedded in the description part of the commits doesn't count. --> This pull request changes the pinout of the blackpillv2 platform. The changes are done as described in the comments of #1418. Table 1: comparing current pinout to proposed pinout | function | current (e490465) | proposal | | -------- | ----------------- | -------- | | nRst | PB4 | PA5 | | nTRST | PB5 (optional) | PA6 (optional) | | TDI | PA1 (also used by LED UART) | PB6 | | TDO | PB3 | PB7 | | TCK | PA14 | PB8 | | TMS | PA13 | PB9 | | PWR | PB8 | PA1 | | UART TX | PB6 | PA2 | | UART RX | PB7 | PA3 | | LED UART | PA1 (also used by TDI) | PA4 | | LED idle run | PC13 | PC13 | | LED error | PC14 | PC14 | | LED boot loader | PC15 | PC15 | | USER KEY | PA0 | PA0 | | USB VBUS | PA9 | PA9 | | USB ID | PA10 | PA10 | | USB D- | PA11 | PA11 | | USB D+ | PA12 | PA12 | | JTAG TMS | - | PA13 | | JTAG TCK | - | PA14 | | JTAG TDI | PA15 | PA15 | | JTAG TDO | - | PB3 | | JTAG TRST | - | PB4 | ![Blackpillv2_pinout_proposal2](https://user-images.githubusercontent.com/10454610/232227414-e9054e58-f32f-42dd-940a-e755abc6669a.png) Figure 1: proposed pinout Benefits: - This pull request fixes the issue described in #1418. Therefore the is no pin conflict anymore between LED UART and TDI. - JTAG pins (PA13, PA14, PA15, PB3, PB4) are not used, such that these pins stay available to program and debug the board. - Pins of the STM32F411Cx that are 5V-intolerant (PB5) are not used, to reduce susceptibility to damage. - Pins of similar type are located closer to each other on the board. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (`make PROBE_HOST=native`) * [x] It builds for hardware blackpillv2 (`make PROBE_HOST=blackpillv2`) * [x] It builds as BMDA (`make PROBE_HOST=hosted`) * [x] I've tested it to the best of my ability: the code compiles, can be flashed and runs on a board with STM32F401CC microcontroller. * [x] My commit messages provide a useful short description of what the commits do ## Closing issues - fixes #1418 <!-- put "fixes #XXXX" here to auto-close the issue(s) that your PR fixes (if any). -->
dragonmux left a comment
Copy link

LGTM. As nobody's complained about the re-jigging of the pinout and as this fixes bugs caused by the pinout, we're going to optimistically merge this and let people open issue tickets if they have any issues.

LGTM. As nobody's complained about the re-jigging of the pinout and as this fixes bugs caused by the pinout, we're going to optimistically merge this and let people open issue tickets if they have any issues.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!1465
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "fix/blackpillv2-pinout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?