Zambyte commented on pull request knightpp/natural-ordering-zig#1 2025年05月23日 16:58:45 +02:00
Simplify iteration

I see. I split it out into two commits so you can just take the first one if you like, but I think both commits better convey intent. unreachable should be used to convey programmer errors, and...

Zambyte pushed to simplify-iter at Zambyte/natural-ordering-zig 2025年05月23日 16:52:57 +02:00
e92b839a68 Convey loop semantics explicitly
6ccadc3edd Simplify iteration
Compare 2 commits »
Zambyte pushed to simplify-iter at Zambyte/natural-ordering-zig 2025年05月23日 16:38:21 +02:00
4be1999174 Simplify iteration
91899fba76 Fix right compare bias
Compare 2 commits »
Zambyte commented on pull request knightpp/natural-ordering-zig#1 2025年05月22日 14:28:00 +02:00
Simplify iteration

I believe this was the only condition that could be met in this block that was deleted, but bias was always .eq, and now that iteration will end at lim, it will hit the return after the for loop, which is also .eq.

Zambyte created pull request knightpp/natural-ordering-zig#1 2025年05月22日 14:15:44 +02:00
Simplify iteration
Zambyte pushed to simplify-iter at Zambyte/natural-ordering-zig 2025年05月22日 14:14:59 +02:00
c92dd85081 Simplify iteration
Zambyte created branch simplify-iter in Zambyte/natural-ordering-zig 2025年05月22日 14:14:58 +02:00
Zambyte created repository Zambyte/natural-ordering-zig 2025年05月22日 14:10:22 +02:00