When using an ImageWriter with 'Code39' the add_checksum option is ignored #55

srolin commented 2019年10月28日 01:21:15 +01:00 (Migrated from github.com)

When using the generator function to create a 'Code39' barcode, the writer_options={'add_checksum': False} is ignored.

The addition of the check digit happens during the class init which hasn't received the writer_options.

I have a fix for this by moving the check into the render function and adding an instance variable to track when it has been added. (I wasn't sure if the render function could end up being called more than once and didn't want additional check digits adding.

Will create a PR for the fix.

When using the generator function to create a 'Code39' barcode, the writer_options={'add_checksum': False} is ignored. The addition of the check digit happens during the class __init__ which hasn't received the writer_options. I have a fix for this by moving the check into the render function and adding an instance variable to track when it has been added. (I wasn't sure if the render function could end up being called more than once and didn't want additional check digits adding. Will create a PR for the fix.

srolin commented 2019年10月28日 15:51:04 +01:00 (Migrated from github.com)

Breaking code:
generate('code39', my_bar_code, writer=ImageWriter(), output='fp_svg', writer_options={'add_checksum': False})
Continued to add a checksum.

Breaking code: `generate('code39', my_bar_code, writer=ImageWriter(), output='fp_svg', writer_options={'add_checksum': False})` Continued to add a checksum.

WhyNotHugo commented 2020年02月25日 02:22:18 +01:00 (Migrated from github.com)

I believe this is fixed. Lemme know if you still have any issues.

I believe this is fixed. Lemme know if you still have any issues.