WhyNotHugo/python-barcode

Fork 0

Code Issues 33 Pull requests 4 Projects Releases 9 Wiki Activity

Redundant information saved in SVG #135

New issue

Closed

opened 2021年12月10日 16:22:01 +01:00 by timsat · 0 comments

timsat commented

2021年12月10日 16:22:01 +01:00

(Migrated from github.com)

Copy link

If i'm not missing something then the generated SVG draws white space over a white background, so what the library generates:

 ...
 <rect width="100%" height="100%" style="fill:white"/>
 <rect x="6.400mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="6.600mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/>
 <rect x="6.800mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="7.000mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/>
 <rect x="7.200mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/>
 <rect x="7.700mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/>
 <rect x="7.900mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="8.100mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:white;"/>
 <rect x="8.600mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="8.800mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/>
 <rect x="9.000mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="9.200mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/>
 <rect x="9.400mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/>
 <rect x="9.900mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:white;"/>
 ...

would be rendered exactly the same as this (without explicit white stripes in between):

 ...
 <rect width="100%" height="100%" style="fill:white"/>
 <rect x="6.400mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="6.800mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="7.200mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/>
 <rect x="7.900mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="8.600mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="9.000mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/>
 <rect x="9.400mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/>
 ...

If my understanding is correct i can submit the MR to optimize SVG output.
Thanks for sharing such a useful project with everybody!

If i'm not missing something then the generated SVG draws white space over a white background, so what the library generates: ```svg ... <rect width="100%" height="100%" style="fill:white"/> <rect x="6.400mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="6.600mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/> <rect x="6.800mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="7.000mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/> <rect x="7.200mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/> <rect x="7.700mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/> <rect x="7.900mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="8.100mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:white;"/> <rect x="8.600mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="8.800mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/> <rect x="9.000mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="9.200mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:white;"/> <rect x="9.400mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/> <rect x="9.900mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:white;"/> ... ``` would be rendered exactly the same as this (without explicit white stripes in between): ```svg ... <rect width="100%" height="100%" style="fill:white"/> <rect x="6.400mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="6.800mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="7.200mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/> <rect x="7.900mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="8.600mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="9.000mm" y="1.000mm" width="0.200mm" height="7.000mm" style="fill:black;"/> <rect x="9.400mm" y="1.000mm" width="0.500mm" height="7.000mm" style="fill:black;"/> ... ``` If my understanding is correct i can submit the MR to optimize SVG output. Thanks for sharing such a useful project with everybody!

No Branch/Tag specified

Branches Tags

main

pre-commit-ci-update-config

extensibility

fix_sizes

feature/longer_guard_bar

ean-without-checksum

readme-formatting

cleaning

cleanup

srolin/master

michieldwitte/left-alignment-fix

Labels

Clear labels

api-inconsistency

inconsistencies in the API between various barcodes or writers

automerge

Automatically merge this PR once CI passes.

bug

contributions welcome

Further design discussions and PRs are welcome.

documentation

things that need to be documented better

more-information-needed

waiting for a reply from the reporter

No labels

contributions welcome

more-information-needed

question

sync

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

WhyNotHugo/python-barcode#135

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?