WhyNotHugo/python-barcode

Fork 0

Code Issues 33 Pull requests 4 Projects Releases 9 Wiki Activity

Added support for Codabar(NW-7) #115

Merged

tetsutalow merged 4 commits from main into main

2021年11月17日 10:48:31 +01:00

Conversation 3 Commits 4 Files changed 4 +103

tetsutalow commented

2021年08月27日 06:02:57 +02:00

(Migrated from github.com)

Copy link

Hi, I just found that this module doesn't support Codabar (also known as NW-7). This is a quick hack to support Codabar. Mostly borrowed from the codes for ITF.

codecov[bot] commented

2021年08月27日 06:03:49 +02:00

(Migrated from github.com)

Copy link

Codecov Report

Merging #115 (274b977) into main (4c0210f) will decrease coverage by 2.44%.
The diff coverage is 32.55%.

❗ Current head 274b977 differs from pull request most recent head b627cb0. Consider uploading reports for the commit b627cb0 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 83.03% 80.58% -2.45% 
==========================================
 Files 15 17 +2 
 Lines 843 886 +43 
==========================================
+ Hits 700 714 +14 
- Misses 143 172 +29

Impacted Files	Coverage Δ
barcode/codabar.py	`27.50% <27.50%> (ø)`
barcode/__init__.py	`95.91% <100.00%> (+0.08%)`	⬆️
barcode/charsets/codabar.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0210f...b627cb0. Read the comment docs.

# [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera) Report > Merging [#115](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera) (274b977) into [main](https://codecov.io/gh/WhyNotHugo/python-barcode/commit/4c0210f22562539b9948eba09b70094ec4f4a036?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera) (4c0210f) will **decrease** coverage by `2.44%`. > The diff coverage is `32.55%`. > :exclamation: Current head 274b977 differs from pull request most recent head b627cb0. Consider uploading reports for the commit b627cb0 to get more accurate results [![Impacted file tree graph](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115/graphs/tree.svg?width=650&height=150&src=pr&token=5jRKlKcg2C&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera)](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera) ```diff @@ Coverage Diff @@ ## main #115 +/- ## ========================================== - Coverage 83.03% 80.58% -2.45% ========================================== Files 15 17 +2 Lines 843 886 +43 ========================================== + Hits 700 714 +14 - Misses 143 172 +29 ``` | [Impacted Files](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera) | Coverage Δ | | |---|---|---| | [barcode/codabar.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera#diff-YmFyY29kZS9jb2RhYmFyLnB5) | `27.50% <27.50%> (ø)` | | | [barcode/\_\_init\_\_.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera#diff-YmFyY29kZS9fX2luaXRfXy5weQ==) | `95.91% <100.00%> (+0.08%)` | :arrow_up: | | [barcode/charsets/codabar.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera#diff-YmFyY29kZS9jaGFyc2V0cy9jb2RhYmFyLnB5) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera). Last update [4c0210f...b627cb0](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/115?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hugo+Osvaldo+Barrera).

WhyNotHugo (Migrated from github.com) reviewed

2021年08月30日 11:42:42 +02:00

WhyNotHugo (Migrated from github.com) left a comment

Copy link

Thanks! Code looks good. I need to generate a few barcodes and confirm with a reader that they work fine, I'll try to address that this week.

I've a few very minor changes nits here.

Thanks! Code looks good. I need to generate a few barcodes and confirm with a reader that they work fine, I'll try to address that this week. I've a few very minor changes nits here.

.gitignore

WhyNotHugo (Migrated from github.com) commented

2021年08月30日 11:40:18 +02:00

Copy link

I'd suggest you add this entry to ~/.config/git/ignore, so that git will ignore it for all repositories that you work on locally, and you don't need to go around adding it everywhere.

I'd suggest you add this entry to `~/.config/git/ignore`, so that git will ignore it for _all_ repositories that you work on locally, and you don't need to go around adding it everywhere. ```suggestion ```

barcode/.gitignore

WhyNotHugo (Migrated from github.com) commented

2021年08月30日 11:41:13 +02:00

Copy link

This is already ignored by .gitignore, so this is redundant.

This is already ignored by [`.gitignore`](https://github.com/WhyNotHugo/python-barcode/blob/4c0210f22562539b9948eba09b70094ec4f4a036/.gitignore#L17), so this is redundant.

WhyNotHugo commented

2021年11月17日 10:48:56 +01:00

(Migrated from github.com)

Copy link

Thanks! Sorry for the delay merging.

Reviewers

No reviewers

Labels

Clear labels

api-inconsistency

inconsistencies in the API between various barcodes or writers

automerge

Automatically merge this PR once CI passes.

bug

contributions welcome

Further design discussions and PRs are welcome.

documentation

things that need to be documented better

more-information-needed

waiting for a reply from the reporter

No labels

contributions welcome

more-information-needed

question

sync

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

WhyNotHugo/python-barcode!115

No description provided.

Delete branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?