Governa commented 2020年12月23日 19:06:41 +01:00 (Migrated from github.com)

This PR tries to partially solve Issue #11

Adds a parameter to both classes that controls if we want longer guard
bars and then while building the code to be generated, use "G" instead of
"1" in those places we will need to have a longer bar.

During the write, interpret every "G" the same as "1" but add an height
factor to the mod list. To avoid changing the entire code base to add a
height parameter, set the self.module_height for every bar generated.

This PR tries to partially solve Issue #11 Adds a parameter to both classes that controls if we want longer guard bars and then while building the code to be generated, use "G" instead of "1" in those places we will need to have a longer bar. During the write, interpret every "G" the same as "1" but add an height factor to the mod list. To avoid changing the entire code base to add a height parameter, set the self.module_height for every bar generated.

codecov[bot] commented 2020年12月23日 19:07:22 +01:00 (Migrated from github.com)

Codecov Report

Merging #100 (a806aa3) into master (7a15b8a) will increase coverage by 1.12%.
The diff coverage is 98.55%.

Impacted file tree graph

@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 81.82% 82.95% +1.12% 
==========================================
 Files 15 15 
 Lines 787 839 +52 
==========================================
+ Hits 644 696 +52 
 Misses 143 143 

Impacted Files	Coverage Δ
barcode/ean.py	91.42% <96.87%> (+2.27%)	⬆️
barcode/__init__.py	95.83% <100.00%> (+0.18%)	⬆️
barcode/writer.py	94.97% <100.00%> (+0.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a15b8a...a806aa3. Read the comment docs.

# [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100?src=pr&el=h1) Report > Merging [#100](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100?src=pr&el=desc) (a806aa3) into [master](https://codecov.io/gh/WhyNotHugo/python-barcode/commit/7a15b8ae1327a194634ab385e88f433f738dc8e0?el=desc) (7a15b8a) will **increase** coverage by `1.12%`. > The diff coverage is `98.55%`. [](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #100 +/- ## ========================================== + Coverage 81.82% 82.95% +1.12% ========================================== Files 15 15 Lines 787 839 +52 ========================================== + Hits 644 696 +52 Misses 143 143 ``` | [Impacted Files](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [barcode/ean.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100/diff?src=pr&el=tree#diff-YmFyY29kZS9lYW4ucHk=) | `91.42% <96.87%> (+2.27%)` | :arrow_up: | | [barcode/\_\_init\_\_.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100/diff?src=pr&el=tree#diff-YmFyY29kZS9fX2luaXRfXy5weQ==) | `95.83% <100.00%> (+0.18%)` | :arrow_up: | | [barcode/writer.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100/diff?src=pr&el=tree#diff-YmFyY29kZS93cml0ZXIucHk=) | `94.97% <100.00%> (+0.73%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100?src=pr&el=footer). Last update [7a15b8a...a806aa3](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/100?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

WhyNotHugo commented 2020年12月23日 20:22:26 +01:00 (Migrated from github.com)

Oh, you can ignore the code-style errors if you want, I can fix those when merging anyway.

Oh, you can ignore the code-style errors if you want, I can fix those when merging anyway.

Governa commented 2020年12月24日 02:48:38 +01:00 (Migrated from github.com)

I've created another PR #101 that fixes all problems with PNG x SVG and some more.

I've created another PR #101 that fixes all problems with PNG x SVG and some more.

Governa commented 2020年12月24日 02:59:06 +01:00 (Migrated from github.com)

PR #100 (this one) with PR #101 should fix #11

PR #100 (this one) with PR #101 should fix #11

WhyNotHugo commented 2020年12月24日 13:56:34 +01:00 (Migrated from github.com)

Looks good, thanks for implementing this, it's been much requested!

Looks good, thanks for implementing this, it's been much requested!