1
0
Fork
You've already forked super
0

Pros / cons of using a char v string literal for the delimiters #1

Closed
opened 2024年11月22日 10:20:45 +01:00 by TimTaylor · 1 comment
TimTaylor commented 2024年11月22日 10:20:45 +01:00 (Migrated from github.com)
Copy link

In the C code we define string literals for the delimiters and then utilise strncmp() during parsing. Would there be much benefit to using chars instead? The comparison could then just use ==. I'm not sure of best practice here so leaving as an issue for future pondering.

In the C code we define string literals for the delimiters and then utilise `strncmp()` during parsing. Would there be much benefit to using chars instead? The comparison could then just use `==`. I'm not sure of best practice here so leaving as an issue for future pondering.
TimTaylor commented 2024年12月20日 10:57:00 +01:00 (Migrated from github.com)
Copy link

Closed by github.com/TimTaylor/super@aac19b50e2. No need for strings if using a single char delim.

Closed by https://github.com/TimTaylor/super/commit/aac19b50e20d7ad69d038cb6837da0b865984ed8. No need for strings if using a single char delim.
Sign in to join this conversation.
No Branch/Tag specified
main
pages
v0.1.1
v0.1.0
v0.0.5
v0.0.4
v0.0.3
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TimTaylor/super#1
Reference in a new issue
TimTaylor/super
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?