Shadow53 commented 2021年05月31日 06:51:43 +02:00 (Migrated from github.com)

This started out as providing support for custom "environment" definitions and turned into a massive refactor. That is still the main change, with the refactor done to facilitate that change.

The other primary change is the introduction and resolution of more lints and errors, including lints for documentation.

This started out as providing support for custom "environment" definitions and turned into a massive refactor. That is still the main change, with the refactor done to facilitate that change. The other primary change is the introduction and resolution of more lints and errors, including lints for documentation.

codecov[bot] commented 2021年06月01日 01:51:19 +02:00 (Migrated from github.com)

Codecov Report

Merging #10 (0ef3131) into main (b85ca62) will increase coverage by 12.39%.
The diff coverage is 70.11%.

Impacted file tree graph

@@ Coverage Diff @@
## main #10 +/- ##
===========================================
+ Coverage 56.53% 68.92% +12.39% 
===========================================
 Files 6 14 +8 
 Lines 826 1194 +368 
 Branches 238 207 -31 
===========================================
+ Hits 467 823 +356 
- Misses 152 206 +54 
+ Partials 207 165 -42 

Impacted Files	Coverage Δ
src/config/builder/hoard.rs	45.20% <45.20%> (ø)
src/config/builder/environment/exe.rs	47.82% <47.82%> (ø)
src/command/mod.rs	50.00% <50.00%> (ø)
src/config/builder/envtrie.rs	67.18% <67.18%> (ø)
src/config/builder/environment/path.rs	68.75% <68.75%> (ø)
src/config/mod.rs	68.75% <68.75%> (ø)
src/config/builder/mod.rs	65.20% <69.94%> (ø)
src/config/builder/environment/mod.rs	70.16% <70.16%> (ø)
src/config/builder/environment/envvar.rs	72.72% <72.72%> (ø)
src/config/builder/environment/os.rs	80.00% <80.00%> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85ca62...0ef3131. Read the comment docs.

# [Codecov](https://codecov.io/gh/Shadow53/hoard/pull/10?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant) Report > Merging [#10](https://codecov.io/gh/Shadow53/hoard/pull/10?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant) (0ef3131) into [main](https://codecov.io/gh/Shadow53/hoard/commit/b85ca62056611043432715fe53f6e72b6bc3b692?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant) (b85ca62) will **increase** coverage by `12.39%`. > The diff coverage is `70.11%`. [](https://codecov.io/gh/Shadow53/hoard/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant) ```diff @@ Coverage Diff @@ ## main #10 +/- ## =========================================== + Coverage 56.53% 68.92% +12.39% =========================================== Files 6 14 +8 Lines 826 1194 +368 Branches 238 207 -31 =========================================== + Hits 467 823 +356 - Misses 152 206 +54 + Partials 207 165 -42 ``` | [Impacted Files](https://codecov.io/gh/Shadow53/hoard/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant) | Coverage Δ | | |---|---|---| | [src/config/builder/hoard.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL2hvYXJkLnJz) | `45.20% <45.20%> (ø)` | | | [src/config/builder/environment/exe.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL2Vudmlyb25tZW50L2V4ZS5ycw==) | `47.82% <47.82%> (ø)` | | | [src/command/mod.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbW1hbmQvbW9kLnJz) | `50.00% <50.00%> (ø)` | | | [src/config/builder/envtrie.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL2VudnRyaWUucnM=) | `67.18% <67.18%> (ø)` | | | [src/config/builder/environment/path.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL2Vudmlyb25tZW50L3BhdGgucnM=) | `68.75% <68.75%> (ø)` | | | [src/config/mod.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9tb2QucnM=) | `68.75% <68.75%> (ø)` | | | [src/config/builder/mod.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL21vZC5ycw==) | `65.20% <69.94%> (ø)` | | | [src/config/builder/environment/mod.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL2Vudmlyb25tZW50L21vZC5ycw==) | `70.16% <70.16%> (ø)` | | | [src/config/builder/environment/envvar.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL2Vudmlyb25tZW50L2VudnZhci5ycw==) | `72.72% <72.72%> (ø)` | | | [src/config/builder/environment/os.rs](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant#diff-c3JjL2NvbmZpZy9idWlsZGVyL2Vudmlyb25tZW50L29zLnJz) | `80.00% <80.00%> (ø)` | | | ... and [15 more](https://codecov.io/gh/Shadow53/hoard/pull/10/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Shadow53/hoard/pull/10?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Shadow53/hoard/pull/10?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant). Last update [b85ca62...0ef3131](https://codecov.io/gh/Shadow53/hoard/pull/10?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Bryant).

Shadow53 commented 2021年06月01日 01:52:36 +02:00 (Migrated from github.com)

This PR is large enough as-is, so the final steps of re-implementing commands will happen in a different branch.

This PR is large enough as-is, so the final steps of re-implementing commands will happen in a different branch.