Improve disk usage limit? #83

acd2048 commented 2025年08月10日 04:55:48 +02:00

Currently, the user can supply any size for max_disk_usage, and oldest recordings are not deleted unless and until they reach that limit. If the drive somehow becomes full (because, for example, the drive is shared with other users, or the user overestimated the drive capacity, or [cough] didn't mount his bulk storage drive correctly), new footage fails to save, while old footage remains.

If max_disk_usage was also (automatically or manually) capped at a percent, or a minimum free space, this would not happen.

I do get that it may not always be ideal -- sometimes it may be better to loose new footage than to loose old footage unexpectedly early -- what do you think?

Currently, the user can supply any size for _max_disk_usage_, and oldest recordings are not deleted unless and until they reach that limit. **If the drive somehow becomes full** (because, for example, the drive is shared with other users, or the user overestimated the drive capacity, or [cough] didn't mount his bulk storage drive correctly), **new footage fails to save, while old footage remains.** If _max_disk_usage_ was also (automatically or manually) capped at a percent, or a minimum free space, this would not happen. I do get that it may not always be ideal -- sometimes it may be better to loose new footage than to loose old footage unexpectedly early -- what do you think?

Curid commented 2025年08月10日 20:02:04 +02:00

I don't think there's a reliable way to get the available space in a directory if the file system supports directory level quotas.

Should we assume that the whole storage directory is on the same drive and that people wont mount a different drive to storage/logs for example?

because, for example, the drive is shared with other users

you generally want to prevent other users from taking your cameras offline by completely filling the disk

or the user overestimated the drive capacity, or [cough] didn't mount his bulk storage drive correctly

this should be noticed pretty quickly, but I guess we could warn on start if max_disk_usage is larger than the disk size

I don't think there's a reliable way to get the available space in a directory if the file system supports directory level quotas. Should we assume that the whole storage directory is on the same drive and that people wont mount a different drive to `storage/logs` for example? > because, for example, the drive is shared with other users you generally want to prevent other users from taking your cameras offline by completely filling the disk > or the user overestimated the drive capacity, or [cough] didn't mount his bulk storage drive correctly this should be noticed pretty quickly, but I guess we could warn on start if `max_disk_usage` is larger than the disk size