update objc dependency to objc2 #45

BillyDM commented 2026年06月09日 00:52:26 +02:00

Looking at the MacOS dependencies again, I noticed that the objc dependency in nice-plug was last updated 7 years ago. We should probably update it to use the new maintained objc2 crate.

Looking at the MacOS dependencies again, I noticed that the `objc` dependency in `nice-plug` was last updated 7 years ago. We should probably update it to use the new maintained `objc2` crate.

sourcebox commented 2026年06月09日 01:04:47 +02:00

I just wanted suggest it. There's also a warning generated with the latest objc:

warning: unexpected `cfg` condition value: `cargo-clippy`
 --> crates/nice-plug/src/event_loop/macos.rs:119:28
 |
119 | unsafe { msg_send![class!(NSThread), isMainThread] }
 | ^^^^^^^^^^^^^^^^
 |
 = note: expected values for `feature` are: `assert_process_allocs`, `default`, `simd`, `standalone`, `unsafe_flush_denormals`, `vst3`, and `zstd`
 = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate
 = help: try referring to `class` crate for guidance on how handle this unexpected cfg
 = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc`
 = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
 = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

I just wanted suggest it. There's also a warning generated with the latest `objc`: ``` warning: unexpected `cfg` condition value: `cargo-clippy` --> crates/nice-plug/src/event_loop/macos.rs:119:28 | 119 | unsafe { msg_send![class!(NSThread), isMainThread] } | ^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `assert_process_allocs`, `default`, `simd`, `standalone`, `unsafe_flush_denormals`, `vst3`, and `zstd` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try referring to `class` crate for guidance on how handle this unexpected cfg = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info) ```