Broken build because of deprecated include of <ciso646> #55

cspiel1 commented 2025年05月22日 08:10:18 +02:00

The issue #53 is not fully fixed. It mentions also the deprecated include of . And this still breaks the build with gcc 15.

I use: g++ (GCC) 15.1.1 20250425

The I tried to build without the unit tests like mentioned.

meson setup -Dunit_tests=disabled -Dtest_programs=disabled -Dselinux=disabled -Dselinux_policy=disabled build
...
 User defined options
 selinux : disabled
 selinux_policy: disabled
 test_programs : disabled
 unit_tests : disabled

$ meson compile -C build
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /home/cspiel/src/openvpn3-linux/build
ninja: Entering directory `/home/cspiel/src/openvpn3-linux/build'
[9/110] Compiling C++ object libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o
FAILED: libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o 
c++ -Ilibnetcfgmgr.a.p -I. -I.. -I../openvpn3-core -I../vendor/asio/asio/include -Isrc -I../src -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libnl3 -I/usr/include/uuid -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=c++17 -O0 -g -Wno-non-virtual-dtor -DOVPN_TINYXML2_HAS_ERROR_NAME -DOVPN_TINYXML2_HAS_ERROR_STR -fPIC -DPROTOBUF_USE_DLLS -DNOMINMAX -pthread -MD -MQ libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o -MF libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o.d -o libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o -c ../src/netcfg/proxy-netcfg-device.cpp
In file included from /usr/include/absl/hash/internal/hash.h:33,
 from /usr/include/absl/hash/hash.h:89,
 from /usr/include/absl/container/internal/hash_function_defaults.h:56,
 from /usr/include/absl/container/hash_container_defaults.h:19,
 from /usr/include/absl/container/flat_hash_map.h:43,
 from /usr/include/google/protobuf/descriptor.h:47,
 from /usr/include/google/protobuf/generated_message_reflection.h:26,
 from src/dco/dco-keyconfig.pb.h:26,
 from ../src/netcfg/proxy-netcfg-device.cpp:37:
/usr/include/c++/15.1.1/ciso646:46:4: error: #warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" [-Werror=cpp]
 46 | # warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros"
 | ^~~~~~~
cc1plus: all warnings being treated as errors
[16/110] Compiling C++ object src/ovpn3cli/libcommandscollection.a.p/commands_session_session-start.cpp.o
ninja: build stopped: subcommand failed.

The issue https://codeberg.org/OpenVPN/openvpn3-linux/issues/53 is not fully fixed. It mentions also the deprecated include of <ciso646>. And this still breaks the build with gcc 15. I use: `g++ (GCC) 15.1.1 20250425` The I tried to build without the unit tests like mentioned. ``` meson setup -Dunit_tests=disabled -Dtest_programs=disabled -Dselinux=disabled -Dselinux_policy=disabled build ... User defined options selinux : disabled selinux_policy: disabled test_programs : disabled unit_tests : disabled ``` ``` $ meson compile -C build INFO: autodetecting backend as ninja INFO: calculating backend command to run: /usr/bin/ninja -C /home/cspiel/src/openvpn3-linux/build ninja: Entering directory `/home/cspiel/src/openvpn3-linux/build' [9/110] Compiling C++ object libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o FAILED: libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o c++ -Ilibnetcfgmgr.a.p -I. -I.. -I../openvpn3-core -I../vendor/asio/asio/include -Isrc -I../src -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libnl3 -I/usr/include/uuid -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=c++17 -O0 -g -Wno-non-virtual-dtor -DOVPN_TINYXML2_HAS_ERROR_NAME -DOVPN_TINYXML2_HAS_ERROR_STR -fPIC -DPROTOBUF_USE_DLLS -DNOMINMAX -pthread -MD -MQ libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o -MF libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o.d -o libnetcfgmgr.a.p/src_netcfg_proxy-netcfg-device.cpp.o -c ../src/netcfg/proxy-netcfg-device.cpp In file included from /usr/include/absl/hash/internal/hash.h:33, from /usr/include/absl/hash/hash.h:89, from /usr/include/absl/container/internal/hash_function_defaults.h:56, from /usr/include/absl/container/hash_container_defaults.h:19, from /usr/include/absl/container/flat_hash_map.h:43, from /usr/include/google/protobuf/descriptor.h:47, from /usr/include/google/protobuf/generated_message_reflection.h:26, from src/dco/dco-keyconfig.pb.h:26, from ../src/netcfg/proxy-netcfg-device.cpp:37: /usr/include/c++/15.1.1/ciso646:46:4: error: #warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" [-Werror=cpp] 46 | # warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" | ^~~~~~~ cc1plus: all warnings being treated as errors [16/110] Compiling C++ object src/ovpn3cli/libcommandscollection.a.p/commands_session_session-start.cpp.o ninja: build stopped: subcommand failed. ```

cspiel1 commented 2025年05月22日 08:20:02 +02:00

Just realized that the issue is caused by googletest like already mentioned here: #53 (comment)

Still open: https://github.com/google/googletest/issues/4701

I'll close this.

Just realized that the issue is caused by googletest like already mentioned here: https://codeberg.org/OpenVPN/openvpn3-linux/issues/53#issuecomment-4147547 Still open: https://github.com/google/googletest/issues/4701 I'll close this.

dazo commented 2025年05月22日 08:56:47 +02:00

@cspiel1 Just curious, which distro are you doing this?

We're doing Fedora 42 builds with GCC-15 and currently disabling unit-tests. But you have a breakage compiling src/netcfg/proxy-netcfg-device.cpp ... and non of the main source code for openvpn3-linux should have ciso646 in the include chain, except via googletest.

Can you try do enter the build directory and do a clean build?

 $ cd build && ninja clean && ninja

@cspiel1 Just curious, which distro are you doing this? We're doing Fedora 42 builds with GCC-15 and currently disabling unit-tests. But you have a breakage compiling `src/netcfg/proxy-netcfg-device.cpp` ... and non of the main source code for openvpn3-linux should have `ciso646` in the include chain, except via googletest. Can you try do enter the build directory and do a clean build? $ cd build && ninja clean && ninja

cspiel1 commented 2025年05月22日 10:55:03 +02:00

I have ArchLinux and use the yay package management tool.

In the meanwhile I think that the cause of the issue is in abseil-cpp. And I found maybe the correct solution and opened a PR: https://github.com/abseil/abseil-cpp/pull/1891

I tried ninja clean && ninja and got the same warning.

Should we keep this issue closed?

I have ArchLinux and use the `yay` package management tool. In the meanwhile I think that the cause of the issue is in `abseil-cpp`. And I found maybe the correct solution and opened a PR: https://github.com/abseil/abseil-cpp/pull/1891 I tried `ninja clean && ninja` and got the same warning. Should we keep this issue closed?

cspiel1 commented 2025年05月22日 11:01:31 +02:00

Another solution could be to ignore the warnings for the build. Thus to remove the -Werror. I could not found where it is set, because I am not very familiar with meson.

Another solution could be to ignore the warnings for the build. Thus to remove the `-Werror`. I could not found where it is set, because I am not very familiar with meson.

dazo commented 2025年05月22日 12:00:51 +02:00

Thus to remove the -Werror. I could not found where it is set, because I am not very familiar with meson.

Just run meson configure -Dwerror=false inside your build directory or add -Dwerror=false when running the meson setup command.

I'll have a look at the apseil-cpp. This feels like it's being out-of-scope for OpenVPN 3 Linux, as it's not this project including the deprecated header.

> Thus to remove the -Werror. I could not found where it is set, because I am not very familiar with meson. Just run `meson configure -Dwerror=false` inside your build directory or add `-Dwerror=false` when running the `meson setup` command. I'll have a look at the apseil-cpp. This feels like it's being out-of-scope for OpenVPN 3 Linux, as it's not this project including the deprecated header.

cspiel1 commented 2025年05月22日 16:16:34 +02:00

The issue was caused by abseil-cpp and is already fixed with: github.com/abseil/abseil-cpp@5f3435aba0

It is still an issue of arch linux. I'll try to report it to them or open a PR.

The issue was caused by abseil-cpp and is already fixed with: https://github.com/abseil/abseil-cpp/commit/5f3435aba00bcd7f12062d2e8e1839b4eaf1a575 It is still an issue of arch linux. I'll try to report it to them or open a PR.

dazo commented 2025年05月23日 18:11:16 +02:00

I've pushed out a new commit (0f80828d73) which should resolve the unit test build failures.

I've also discussed this abseil-cpp issue with a colleague also running Arch. He does the -Dwerror=false apprach for now too.

This issue is not something which should be fixed (or, in practice, worked around) in OpenVPN 3 Linux. We are currently requiring the C++17 standard, while the abseil-cpp seems to require C++20 to be enabled. The OpenVPN 3 Core library version used (latest stable, v3.11.1) is also not C++20 compliant (it will be in v3.12). There are also still a few issues left in the OpenVPN 3 Linux addon-aws which needs to be fixed.

Getting C++20 compliant is not within the v25 scope (the next major release). The v26 release will most likely move to C++20.

So for now, until either abseil-cpp is fixed to be C++17 compliant or the v26 is released (no ETA) .... this needs to be worked around using -Dwerror=false.

I've pushed out a new commit (0f80828d73856be223cdc9878f7c096ffe58759f) which should resolve the unit test build failures. I've also discussed this abseil-cpp issue with a colleague also running Arch. He does the `-Dwerror=false` apprach for now too. This issue is not something which should be fixed (or, in practice, worked around) in OpenVPN 3 Linux. We are currently requiring the C++17 standard, while the abseil-cpp seems to require C++20 to be enabled. The OpenVPN 3 Core library version used (latest stable, v3.11.1) is also not C++20 compliant (it will be in v3.12). There are also still a few issues left in the OpenVPN 3 Linux `addon-aws` which needs to be fixed. Getting C++20 compliant is not within the `v25` scope (the next major release). The `v26` release will most likely move to C++20. So for now, until either abseil-cpp is fixed to be C++17 compliant or the `v26` is released (no ETA) .... this needs to be worked around using `-Dwerror=false`.