Describe the bug
In OSM Dashboard are no longer the statistics present for the tracks shown.
It worked before with the same osm dashboard version, so I think it is open track related
OSM Dashboard statistics are gone #2255
Thanks for your report. I'll have a look.
I renamed one column recently (IIRC category). Could that be it?
Yes, category is used:
const val CATEGORY = "category" // track activity type
@dennisguse what do we do? Revert OpenTracks or update the protocol version and change the column name in OSMDashboard, too?
I will rollback the change + create a new release. This has to wait until reproducible builds are working again for OSMdashboard. And yes, the protocol version should have been incremented as well.
Damn. Rolling back is not that easy: I removed and renamed a lot of columns for the tracks table.
ca64f2c749must be reverted- Migrations from
ca64f2c749cherry-picked - Database version set to 38 (again)
- Create a new release
Follow-up:
-
Re-apply
ca64f2c749 -
Remove workaround
//TODO Workaround: Column icon was removed in v4.24.0, but is still required for OSMDashboard v6.4.1. -
Increment protocol version
Damn downgrading is actual effort as the database change was done before adding temperature (and I was cleaning up a lot).
I will bump the protocol version and create a release.
Ok, so OSMDashboard has to use the new column name for protocol version 3?
Actually, all the column names: I renamed the ones in TracksColumns to make it more maintainable.
If we are going down this road: I would also rename the MarkerColumns.
As alternative, I was also looking into creating a separate ContentProvider that maps OpenTracks internal tables to an interface.
I am not sure how much effort this will be.
I'll implement protocol version 3 in OSMDashboard.
Support for protocol version 3 should be available in the next nightly build.
@dennisguse what do you want to change in the MarkerColumns? Then we can put it in v3 as well.
@pstorch Like this: 1369d3ef9f
Added suport for MarkerColumns V3 in OSMDashboard
Change released with OpenTracks v4.25.1
Fdroid may take some days.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?