4
9
Fork
You've already forked PipePipeClient
7

[New Feature] [BiliBili] Display comment pictures in dialog #13

Closed
chr_56 wants to merge 3 commits from chr_56:bilibili_comment_pictures_client into dev
pull from: chr_56:bilibili_comment_pictures_client
merge into: NullPointerException:dev
NullPointerException:dev
NullPointerException:legacy
NullPointerException:main
Contributor
Copy link

Use PictureDialog to view pictures in comments.

This contains:

  1. extend CommentsInfoItem to store attached pictures in the format of Image;
  2. create PictureDialog to view pictures via CommentsInfoItemHolder.

Currently, it's in state of "just working" requiring ongoing refinement and polish.

This requires correspond extractor/client PR.

Use `PictureDialog` to view pictures in comments. This contains: 1. extend `CommentsInfoItem` to store attached pictures in the format of `Image`; 2. create `PictureDialog` to view pictures via `CommentsInfoItemHolder`. Currently, it's in state of "just working" requiring ongoing refinement and polish. **This requires correspond extractor/client PR.**
Author
Contributor
Copy link

I currently can not open PR in extractor side.
Codeberg is in 500 Internal Server Error when I try to create PR in Extractor.

I currently can not open PR in extractor side. Codeberg is in `500 Internal Server Error` when I try to create PR in Extractor.
chr_56 force-pushed bilibili_comment_pictures_client from 25ac52348e to cde75f517f 2023年12月28日 03:29:36 +01:00 Compare

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
NullPointerException/PipePipeClient!13
Reference in a new issue
NullPointerException/PipePipeClient
No description provided.
Delete branch "chr_56:bilibili_comment_pictures_client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?