Merge Upstream: DescriptionFragment with imaging extracting #12

chr_56 commented 2023年12月28日 02:57:54 +01:00

Merge upstream changes on Description fragments with relative utilities update:

1. Upstream pulled up a BaseDescriptionFragment and use it in Channel's about tab, and introduced
   a model class Image in extractor to improve avatars and thumbnails extracting.
2. All image url extracting method are replaced with corresponding Image collection extracting
   method, but I
   kept the legacy codes and redirected to the legacy since we can not afford large changes on
   "unmaintained" services.
3. refactoring of TextLinkifier with new text-span utils from upstream.

This as well results in supporting various size images extracting instead of one url in Metadata
section.

This requires correspond extractor/client PR.

Merge upstream changes on Description fragments with relative utilities update: 1) Upstream pulled up a `BaseDescriptionFragment` and use it in Channel's about tab, and introduced a model class `Image` in extractor to improve avatars and thumbnails extracting. 2) All image url extracting method are replaced with corresponding `Image` collection extracting method, but I kept the legacy codes and redirected to the legacy since we can not afford large changes on "unmaintained" services. 3) refactoring of `TextLinkifier` with new text-span utils from upstream. This as well results in supporting various size images extracting instead of one url in Metadata section. **This requires correspond extractor/client PR.**

chr_56 commented 2023年12月28日 03:12:40 +01:00

I currently can not open PR in extractor side.
Codeberg is in 500 Internal Server Error when I try to create PR in Extractor.

I currently can not open PR in extractor side. Codeberg is in `500 Internal Server Error` when I try to create PR in Extractor.

NullPointerException commented 2023年12月30日 02:43:04 +01:00

Channel's about tab

I believe you want to say Stream's description tab right?

Let's sort things up:

1. It introduces BaseDescriptionFragment, which can be used for #14 to support more statistics
2. It introduces Image, which can be used for #13 to show images in-app.
3. TextLinkifier -> seems no benefits, only for compatibility.

Things will be affected:

• Stream's description tab
• Thumbnails
• Text links

We need to make sure text links still work as expected, at least for cases in https://github.com/InfinityLoop1308/PipePipe/issues/64 and https://github.com/InfinityLoop1308/PipePipe/issues/71

> Channel's about tab I believe you want to say Stream's description tab right? Let's sort things up: 1. It introduces `BaseDescriptionFragment`, which can be used for #14 to support more statistics 2. It introduces `Image`, which can be used for #13 to show images in-app. 3. `TextLinkifier` -> seems no benefits, only for compatibility. Things will be affected: - Stream's description tab - Thumbnails - Text links We need to make sure text links still work as expected, at least for cases in https://github.com/InfinityLoop1308/PipePipe/issues/64 and https://github.com/InfinityLoop1308/PipePipe/issues/71

NullPointerException commented 2023年12月30日 02:46:30 +01:00

Also does Image solve https://github.com/InfinityLoop1308/PipePipe/issues/166 ?

Also does `Image` solve https://github.com/InfinityLoop1308/PipePipe/issues/166 ?

chr_56 commented 2023年12月30日 03:22:44 +01:00

Also does Image solve https://github.com/InfinityLoop1308/PipePipe/issues/166 ?

No, just a model class in Extractor. No change on "View and UI" in Client has been made.

I just extend the DescriptionFragment - some changes only available for text.

> Also does `Image` solve https://github.com/InfinityLoop1308/PipePipe/issues/166 ? No, just a model class in Extractor. _No_ change on "View and UI" in Client has been made. I just extend the DescriptionFragment - some changes only available for text.

chr_56 commented 2023年12月30日 03:29:14 +01:00

Things will be affected:

• Stream's description tab
• Thumbnails
• Text links

1. Stream and Channel's description tab.
2. Thumbnails extracting: We kept the old api; only new DescriptionFragment uses it. Only effect should be text.
3. Text links shall be compact.

> Things will be affected: > - Stream's description tab > - Thumbnails > - Text links 1. Stream and Channel's description tab. 2. Thumbnails extracting: We kept the old api; only new DescriptionFragment uses it. Only effect should be text. 3. Text links shall be compact.