Editing FRU if the length of the field is not equal the original field will return EXIT_FAILURE #81

CrazyCat commented 2026年03月04日 16:22:07 +01:00

I think it's a bug

When editing FRU, if the length of the field being modified does not match the original field, "ipmi_fru_set_field_string_rebuild" will be executed. This function returns 1 if successfully, yet the current logic sets rc= -1, resulting in the ipmitool command returning EXIT_FAILURE as its exit code.

Please see the code in ipmitool/lib/ipmi_fru.c:
image

I if "ipmi_fru_set_field_string_rebuild" returns 1, rc will be set 1

I think it's a bug When editing FRU, if the length of the field being modified does not match the original field, "**_ipmi_fru_set_field_string_rebuild_**" will be executed. This function returns 1 if successfully, yet the current logic sets **_rc= -1_**, resulting in the ipmitool command returning _EXIT_FAILURE_ as its exit code. Please see the code in _ipmitool/lib/ipmi_fru.c_:  I if "**_ipmi_fru_set_field_string_rebuild_**" returns 1, rc will be set 1

AlexanderAmelkin commented 2026年03月30日 23:21:38 +02:00

Thanks for the catch. This should be fixed in #82.

Nonetheless, I strongly recommend using https://codeberg.org/IPMITool/frugen for FRU modification, as it is much more versatile and flexible, plus it better supports the FRU specification.

You can use ipmitool fru read to read the binary file, then modify it with frugen, then write it back with ipmitool fru write.

Probably, at some point in the future I will bring libfru from frugen to ipmitool to replace the currently existing fru handling code, because to be honest, the currently existing code here is quite dirty.

Thanks for the catch. This should be fixed in #82. Nonetheless, I strongly recommend using https://codeberg.org/IPMITool/frugen for FRU modification, as it is much more versatile and flexible, plus it better supports the FRU specification. You can use `ipmitool fru read` to read the binary file, then modify it with `frugen`, then write it back with `ipmitool fru write`. Probably, at some point in the future I will bring `libfru` from `frugen` to `ipmitool` to replace the currently existing fru handling code, because to be honest, the currently existing code here is quite dirty.