SEL: cannot display Sensor name when sensor owner lun1 #8

XinyuLu commented 2023年08月04日 07:44:01 +02:00

Describe the bug
SEL: cannot display SEL's SensorName when sensor owner lun1

IPMITOOL Version

ipmitool-Master % src/ipmitool -V
ipmitool version 1.8.19.13.gbe11d94

To Reproduce
Steps to reproduce the behavior:

1. Using AMI/BMC to generate a sensor error event. The sensor belong to LUN1
   GPU1_MEM | 10h | ok | 11.1 | Uncorrectable ECC
   GPU2_MEM | 11h | ok | 11.2 | Uncorrectable ECC
   GPU3_MEM | 12h | ok | 11.3 | Uncorrectable ECC
   GPU4_MEM | 13h | ok | 11.4 | Uncorrectable ECC
   GPU5_MEM | 14h | ok | 11.5 | Uncorrectable ECC
   GPU6_MEM | 15h | ok | 11.6 | Uncorrectable ECC
   GPU7_MEM | 16h | ok | 11.7 | Uncorrectable ECC
   GPU8_MEM | 17h | ok | 11.8 | Uncorrectable ECC
2. Run ipmitool sel elist
3. Observe the abnormal reply:
   c5 | 2023年08月02日 | 17时17分24秒 CST | Memory | Uncorrectable ECC | Asserted
   c6 | 2023年08月02日 | 17时18分29秒 CST | Memory | Uncorrectable ECC | Asserted
   c7 | 2023年08月02日 | 17时18分29秒 CST | Memory | Uncorrectable ECC | Asserted
   c8 | 2023年08月02日 | 17时18分30秒 CST | Memory | Uncorrectable ECC | Asserted
   c9 | 2023年08月02日 | 17时18分30秒 CST | Memory | Uncorrectable ECC | Asserted
   ca | 2023年08月02日 | 17时19分34秒 CST | Memory | Uncorrectable ECC | Asserted
   cb | 2023年08月02日 | 17时19分34秒 CST | Memory INTEGRAL_DIMM | Uncorrectable ECC | Asserted
   cc | 2023年08月02日 | 17时19分34秒 CST | Memory | Uncorrectable ECC | Asserted
   SensorName is empty or wrong.(Expexct GPU1_MEM)

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

**Describe the bug** SEL: cannot display SEL's SensorName when sensor owner lun1 **IPMITOOL Version** ipmitool-Master % src/ipmitool -V ipmitool version 1.8.19.13.gbe11d94 **To Reproduce** Steps to reproduce the behavior: 1. Using AMI/BMC to generate a sensor error event. The sensor belong to LUN1 GPU1_MEM | 10h | ok | 11.1 | Uncorrectable ECC GPU2_MEM | 11h | ok | 11.2 | Uncorrectable ECC GPU3_MEM | 12h | ok | 11.3 | Uncorrectable ECC GPU4_MEM | 13h | ok | 11.4 | Uncorrectable ECC GPU5_MEM | 14h | ok | 11.5 | Uncorrectable ECC GPU6_MEM | 15h | ok | 11.6 | Uncorrectable ECC GPU7_MEM | 16h | ok | 11.7 | Uncorrectable ECC GPU8_MEM | 17h | ok | 11.8 | Uncorrectable ECC 2. Run `ipmitool sel elist` 3. Observe the abnormal reply: c5 | 2023年08月02日 | 17时17分24秒 CST | Memory | Uncorrectable ECC | Asserted c6 | 2023年08月02日 | 17时18分29秒 CST | Memory | Uncorrectable ECC | Asserted c7 | 2023年08月02日 | 17时18分29秒 CST | Memory | Uncorrectable ECC | Asserted c8 | 2023年08月02日 | 17时18分30秒 CST | Memory | Uncorrectable ECC | Asserted c9 | 2023年08月02日 | 17时18分30秒 CST | Memory | Uncorrectable ECC | Asserted ca | 2023年08月02日 | 17时19分34秒 CST | Memory | Uncorrectable ECC | Asserted cb | 2023年08月02日 | 17时19分34秒 CST | Memory INTEGRAL_DIMM | Uncorrectable ECC | Asserted cc | 2023年08月02日 | 17时19分34秒 CST | Memory | Uncorrectable ECC | Asserted SensorName is empty or wrong.(Expexct GPU1_MEM) **Expected behavior** A clear and concise description of what you expected to happen. **Additional context** Add any other context about the problem here.

AlexanderAmelkin commented 2025年11月12日 19:28:35 +01:00

Unfortunately, I don't have any hardware that uses LUN1 for sensors, so I can't debug, and it's not obvious from the code why it behaves this way. If you could debug it and post a PR, I would gladly accept it.

Unfortunately, I don't have any hardware that uses LUN1 for sensors, so I can't debug, and it's not obvious from the code why it behaves this way. If you could debug it and post a PR, I would gladly accept it.

AlexanderAmelkin commented 2025年11月12日 23:01:24 +01:00

From the code of ipmitool it looks to me like it should work properly if your BMC sets the Generator ID field properly.
According to specification, it must be:
image

According to the code in ipmi_sdr_find_sdr_bynumtype(), the IPMB Slave Address is not checked and LUN is always extracted from bits [1:0] of Byte 2.

Most probably, your BMC doesn't specify LUN in the SEL records. Please check that by running ipmitool in verbose mode to see the actual bytes you get from your BMC. If you find out that the SEL records your BMC reports actually do contain a proper LUN in the Generator ID field, then feel free to reopen this bug (if available) or create new one with all that new debug info added.

From the code of `ipmitool` it looks to me like it should work properly if your BMC sets the Generator ID field properly. According to specification, it must be:  According to the code in `ipmi_sdr_find_sdr_bynumtype()`, the `IPMB Slave Address` is not checked and LUN is always extracted from bits [1:0] of Byte 2. Most probably, your BMC doesn't specify LUN in the SEL records. Please check that by running `ipmitool` in verbose mode to see the actual bytes you get from your BMC. If you find out that the SEL records your BMC reports actually do contain a proper LUN in the Generator ID field, then feel free to reopen this bug (if available) or create new one with all that new debug info added.