clangd identified a buffer overrun #23

Howitzer105mm commented 2024年02月09日 21:23:22 +01:00

Describe the bug
There is a buffer overrun condition in src/plugins/open/open.c
The ipmi_dev2fs2 variable is too small by one byte.

IPMITOOL Version

Make sure you're reporting a bug in the latest code taken from master branch here, NOT a bug
that you've found in some version that you've got from your OS vendor or any source other than this repository.

ipmitool version 1.8.19.16.g81b8242

To Reproduce
Steps to reproduce the behavior:

1. clangd reports 17 bytes are needed to store the formatted string. Only 16 are available.

Expected behavior
clangd will not report errors on the buffer.

Additional context
Add any other context about the problem here.

**Describe the bug** There is a buffer overrun condition in src/plugins/open/open.c The ipmi_dev2fs2 variable is too small by one byte. **IPMITOOL Version** Make sure you're reporting a bug in the latest code taken from `master` branch here, NOT a bug that you've found in some version that you've got from your OS vendor or any source other than this repository. ```ipmitool version 1.8.19.16.g81b8242``` **To Reproduce** Steps to reproduce the behavior: 1. clangd reports 17 bytes are needed to store the formatted string. Only 16 are available. **Expected behavior** clangd will not report errors on the buffer. **Additional context** Add any other context about the problem here.

Howitzer105mm commented 2024年03月29日 19:30:19 +01:00

Resolved with commit:
9564746d3f ipmievd: Eliminate a possible command line overrun (#27)

Resolved with commit: 9564746d3f37930383472214055692ec4c1ba3d4 ipmievd: Eliminate a possible command line overrun (#27)

Howitzer105mm commented 2024年03月29日 19:32:12 +01:00

Correction:
b4bc5c3351 open: Eliminate buffer overrun (#24)

Correction: b4bc5c335159b1c272e06dba98e2916e3ecc0462 open: Eliminate buffer overrun (#24)