11
29
Fork
You've already forked ipmitool
33

Changing HAVE_CRYPTO_MDx in config.h does not change the conditional compilation #21

Closed
opened 2024年02月09日 20:00:34 +01:00 by Howitzer105mm · 1 comment
Contributor
Copy link

Describe the bug
The config.h file contains HAVE_CRYPTO_MD5 and _MD2. Setting these values from 1 to 0 does not change which code is compiled inside of auth.c.
It is necessary to remove these entries from config.h to change the #ifdef/#else/#endif behavior.
The assumption is setting these config.h entries to 0 is supposed to enable the #else clause in the code.

IPMITOOL Version

Make sure you're reporting a bug in the latest code taken from master branch here, NOT a bug
that you've found in some version that you've got from your OS vendor or any source other than this repository.

ipmitool version 1.8.19.16.g81b8242

To Reproduce
Steps to reproduce the behavior:

  1. Change HAVE_CRYPTO_MD5 to 0
  2. Compile the source
  3. Observe the abnormal reply:

Expected behavior
When either of these switches is set to 0 there should be no OpenSSL compile time errors.

Additional context
Add any other context about the problem here.

**Describe the bug** The config.h file contains HAVE_CRYPTO_MD5 and _MD2. Setting these values from 1 to 0 does not change which code is compiled inside of auth.c. It is necessary to remove these entries from config.h to change the #ifdef/#else/#endif behavior. The assumption is setting these config.h entries to 0 is supposed to enable the #else clause in the code. **IPMITOOL Version** Make sure you're reporting a bug in the latest code taken from `master` branch here, NOT a bug that you've found in some version that you've got from your OS vendor or any source other than this repository. ```ipmitool version 1.8.19.16.g81b8242``` **To Reproduce** Steps to reproduce the behavior: 1. Change HAVE_CRYPTO_MD5 to 0 2. Compile the source 3. Observe the abnormal reply: ```Observe that OpenSSL compile time errors get emitted. ``` **Expected behavior** When either of these switches is set to 0 there should be no OpenSSL compile time errors. **Additional context** Add any other context about the problem here.
Author
Contributor
Copy link

Issue has been resolved.

Issue has been resolved.
Sign in to join this conversation.
No Branch/Tag specified
master
bugfix/43-Fix-timezone-and-DST-in-SEL
pages
bugfix/fix-ci-builds
feature/refactor-sdr-name-handling
cleanup/nm
feature/add-support-for-boot-mailbox
codefactor
bugfix/26
IPMITOOL_1_8_19
IPMITOOL_1_8_18
IPMITOOL_1_8_17
IPMITOOL_1_8_16
IPMITOOL_1_8_15
IPMITOOL_1_8_15RC1
IPMITOOL_1_8_14
IPMITOOL_1_8_14RC2
IPMITOOL_1_8_14RC1
ipmitool
IPMITOOL_1_8_13
IPMITOOL_1_8_13RC1
IPMITOOL_1_8_12
IPMITOOL_1_8_9
IPMITOOL_1_8_8
IPMITOOL_1_8_7
IPMITOOL_1_8_6
IPMITOOL_1_8_5
IPMITOOL_1_8_0
IPMITOOL_S10_U1
IPMITOOL_1_6_1
IPMITOOL_1_6_0
IPMITOOL_1_5_9
IPMITOOL_1_5_8
IPMITOOL_1_5_7
IPMITOOL_1_5_6
IPMITOOL_1_5_4
IPMITOOL_1_4_1_1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IPMITool/ipmitool#21
Reference in a new issue
IPMITool/ipmitool
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?