Not working properly on 32-bit architectures #14

harryleafchen commented 2025年08月18日 15:57:32 +02:00

When packaging for debian, I found the current 3.0 release does not work normally on 32-bit architectures.

Please see the example from i386 and armhf.

The test commands are very simple:

frugen -j example.json fru.bin
frugen -r fru.bin -o text -

And the error message is Failed to encode the provided data: Not an even number of nibbles in Internal Use Area.

I have not dug into the code, but it looks like some struct padding / data truncation problem to me.

When packaging for debian, I found the current 3.0 release does not work normally on 32-bit architectures. Please see the example from [i386](https://ci.debian.net/packages/f/frugen/testing/i386/63306957/) and [armhf](https://ci.debian.net/packages/f/frugen/testing/armhf/63279656/). The test commands are very simple: ``` frugen -j example.json fru.bin frugen -r fru.bin -o text - ``` And the error message is `Failed to encode the provided data: Not an even number of nibbles in Internal Use Area`. I have not dug into the code, but it looks like some struct padding / data truncation problem to me.

AlexanderAmelkin commented 2025年08月26日 20:51:53 +02:00

I will look into it, thanks

I will look into it, thanks

AlexanderAmelkin commented 2025年08月26日 20:52:39 +02:00

Have you tried the latest version from master? It has a number of fixes atop of release 3.0

Have you tried the latest version from master? It has a number of fixes atop of release 3.0

harryleafchen commented 2025年08月27日 17:19:29 +02:00

@AlexanderAmelkin I can confirm this persists on the latest master commit on i686.

@AlexanderAmelkin I can confirm this persists on the latest master commit on i686.

harryleafchen commented 2025年08月27日 17:22:27 +02:00

If you are using debian or similar, you may try something like:

sudo dpkg --add-architecture i386 && sudo apt update
sudo apt install gcc-i686-linux-gnu libjson-c-dev:i686
CC=i686-linux-gnu-gcc cmake -B build -S .
cmake --build
file build/frugen # check it is 32-bit

The generated build/frugen would report the aforementioned error.

If you are using debian or similar, you may try something like: ``` sudo dpkg --add-architecture i386 && sudo apt update sudo apt install gcc-i686-linux-gnu libjson-c-dev:i686 CC=i686-linux-gnu-gcc cmake -B build -S . cmake --build file build/frugen # check it is 32-bit ``` The generated `build/frugen` would report the aforementioned error.

AlexanderAmelkin commented 2025年10月27日 20:32:36 +01:00

It's strange that you hit the Failed to encode... error. With the current master I get a Segmentation fault on the first command due to custom MR record in example.json. When I fix that, both your example commands run just fine for me.

Please try 6643c5cdfc

It's strange that you hit the `Failed to encode...` error. With the current master I get a `Segmentation fault` on the first command due to `custom` MR record in `example.json`. When I fix that, both your example commands run just fine for me. Please try 6643c5cdfce30e0773020172213b2a18dc4ccaa4

harryleafchen commented 2025年10月28日 02:47:36 +01:00

@AlexanderAmelkin I can confirm it is fixed in the latest master (6643c5cdfc) -- yet I am also confused why it hit that branch, might be some UB previously?

@AlexanderAmelkin I can confirm it is fixed in the latest master (6643c5cdfc) -- yet I am also confused why it hit that branch, might be some UB previously?

AlexanderAmelkin commented 2025年10月30日 11:58:48 +01:00

Well, all I can say is that gcc is run with -fanalyzer now during builds and it doesn't detect any UBs in the code

Well, all I can say is that `gcc` is run with `-fanalyzer` now during builds and it doesn't detect any UBs in the code