-
Joined on
2023年10月25日
Created two constants per your suggestion.
Restored the formatting.
I prefer returning the already calculated string length. The function has already determined the size of the string. This makes using strlen() unnecessary. Why recalculate the string length using...
Looks like I need to update this PR. I did not adjust for the six bits of the FRU Type/Len record.
Modified to be less temporal
Cleaned formatting
I have added the string length #define, and described why that number is being used. It is also being used for the FRU records as well. There is bug in the OpenBMC IPMI code. The Type encoding...
This is one of those places where the Type/Len already allowed 31 bytes:
` memset(desc, 0, sizeof(desc)); memcpy(desc, fru->id_string, __min(fru->id_code & 0x01f, sizeof(desc))); desc[fru->i...
FWIW, I avoided creating the #defines you recommended, as there were already bunches of hard coded values. I was not certain creating the #defines would have been approved, so I left the code with...
The reason for using 42 is due to using non-integer math:
The assumption is that the Type/Len can/will be assigned 0x1F. There is already ample code within ipmitool allowing this, for example...
Do you have any additional feedback Alexander?
The Multi-record byte 3 is the length of the current record. You have to check bit 7 of byte 2 to see if this is the last record. If it isn't you will find an appended multi-record entry. The...
Pushed a new version with the change you requested.