NameError for Line attribute 'rise' #3

mdnabiltech commented 2020年07月22日 01:25:22 +02:00

Error:

Python 3.8.2 (default, Apr 27 2020, 15:53:34)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from gasp import *
>>> begin_graphics()
>>> Line((200,200),(150,350))
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 File "/home/mdnabiltech/Projects/GASP/GASP_Tkinter/gasp/gasp.py", line 162, in __repr__
 f"<Line object from ({self.pos[0]}, {self.pos[1]})>"
NameError: name 'rise' is not defined

Gasp.py File:

class Line:
 """Draw a line segment between p1 and p2."""
 def __init__(self, p1, p2, color=color.BLACK, thickness=1):
 self.pos = p1
 self.rise = p2[0] - p1[0]
 self.run = p2[1] - p1[1]
 self.coord_list = [
 p1[0],
 _canvas_ys - p1[1],
 p2[0],
 _canvas_ys - p2[1]
 ]
 self.id = _canvas.create_line(*self.coord_list, fill=color, width=thickness)
 _canvas.update()
 def __repr__(self):
 return (
 f"<Line object from ({self.pos[0]}, {self.pos[1]})>"
 f" to ({self.pos[0] + rise}, {self.pos[1] - run})>"
 )

**Error:** ``` Python 3.8.2 (default, Apr 27 2020, 15:53:34) [GCC 9.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from gasp import * >>> begin_graphics() >>> Line((200,200),(150,350)) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/mdnabiltech/Projects/GASP/GASP_Tkinter/gasp/gasp.py", line 162, in __repr__ f"<Line object from ({self.pos[0]}, {self.pos[1]})>" NameError: name 'rise' is not defined ``` **Gasp.py File:** ``` class Line: """Draw a line segment between p1 and p2.""" def __init__(self, p1, p2, color=color.BLACK, thickness=1): self.pos = p1 self.rise = p2[0] - p1[0] self.run = p2[1] - p1[1] self.coord_list = [ p1[0], _canvas_ys - p1[1], p2[0], _canvas_ys - p2[1] ] self.id = _canvas.create_line(*self.coord_list, fill=color, width=thickness) _canvas.update() def __repr__(self): return ( f"<Line object from ({self.pos[0]}, {self.pos[1]})>" f" to ({self.pos[0] + rise}, {self.pos[1] - run})>" ) ```

mdnabiltech commented 2020年07月22日 02:21:49 +02:00

Turns out the problem was in both 'rise' and 'run'. As I got this too:

Python 3.8.2 (default, Apr 27 2020, 15:53:34)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from gasp import *
>>> begin_graphics()
>>> Line((100,100),(200,200))
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 File "/home/mdnabiltech/Projects/GASP/GASP_Tkinter/gasp/gasp.py", line 162, in __repr__
 f"<Line object from ({self.pos[0]}, {self.pos[1]})>"
NameError: name 'run' is not defined

I looked in the gasp.py file and I fixed it with a quick fix of just adding 'self.' to the start of the attributes.

The correct code for line 163 is:
f" to ({self.pos[0] + self.rise}, {self.pos[1] - self.run})>"

as opposed to:
f" to ({self.pos[0] + rise}, {self.pos[1] - run})>"

Turns out the problem was in both 'rise' and 'run'. As I got this too: ``` Python 3.8.2 (default, Apr 27 2020, 15:53:34) [GCC 9.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from gasp import * >>> begin_graphics() >>> Line((100,100),(200,200)) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/mdnabiltech/Projects/GASP/GASP_Tkinter/gasp/gasp.py", line 162, in __repr__ f"<Line object from ({self.pos[0]}, {self.pos[1]})>" NameError: name 'run' is not defined ``` I looked in the gasp.py file and I fixed it with a quick fix of just adding 'self.' to the start of the attributes. The correct code for line 163 is: `f" to ({self.pos[0] + self.rise}, {self.pos[1] - self.run})>"` as opposed to: `f" to ({self.pos[0] + rise}, {self.pos[1] - run})>"`

jelkner commented 2020年07月22日 02:57:54 +02:00

Nice work, Nabil! First I added a test for this to test_api.py, then I applied your fix. Actually, we need self.pos[1] - self.run. I'm only adding high level, "functional tests". We should also add lower level, programmer oriented "unit tests" to test the math that is being done to transform the coordinate system.

Anyway, for now the fix has been commited.

Nice work, Nabil! First I added a test for this to test_api.py, then I applied your fix. Actually, we need self.pos[1] - self.run. I'm only adding high level, "functional tests". We should also add lower level, programmer oriented "unit tests" to test the math that is being done to transform the coordinate system. Anyway, for now the fix has been commited.