In the current version of GASP, the Arc class is defined as so:
>>> Arc(position, radius, start_angle, end_angle)
My interpretation of this was that the arc would start and end at those angles (hence the name). For example:
>>> Arc((300, 200), 100, 90, 180)
would produce an arc as shown in the first image below. The arc starts at 90 degrees and ends at 180 degrees for a total of 90 degrees travelled by the arc. (Image 1)
However, this line when run produces an arc that starts at 90 degrees but then travels for 180 degrees total. (Image 2)
In my interpretation, Image 2 would instead be created by:
>>> Arc((300, 200), 100, 90, 270)
This would create an arc that starts at 90 degrees (straight up) and ends at 270 degrees (straight down). Maybe the class is intended to work this way, but to my math oriented brain, "start angle" and "end angle" mean just that: where the arc starts and where it ends.
This would be a relatively easy fix. After some thinking and tinkering around in the gasp module, I found the fix. On this line of gasp.py, replace:
extent=end_angle,
with:
extent=end_angle-start_angle,
This makes the class work the way I expected. I assumed correctly that "extent" meant how far the arc should travel. By subtracting off the start angle, the arc instead ends at the given angle rather than travelling that far. Of course if the previous functionally is meant to stay intact, maybe it could become an option?
Hope this helps.
In the current version of GASP, the Arc class is defined as so:
`>>> Arc(position, radius, start_angle, end_angle)`
My interpretation of this was that the arc would start and end at those angles (hence the name). For example:
`>>> Arc((300, 200), 100, 90, 180)`
would produce an arc as shown in the first image below. The arc starts at 90 degrees and ends at 180 degrees for a total of 90 degrees travelled by the arc. (Image 1)
However, this line when run produces an arc that starts at 90 degrees but then travels for 180 degrees total. (Image 2)
In my interpretation, Image 2 would instead be created by:
`>>> Arc((300, 200), 100, 90, 270)`
This would create an arc that starts at 90 degrees (straight up) and ends at 270 degrees (straight down). Maybe the class is intended to work this way, but to my math oriented brain, "start angle" and "end angle" mean just that: where the arc starts and where it ends.
This would be a relatively easy fix. After some thinking and tinkering around in the gasp module, I found the fix. On [this](https://codeberg.org/GASP/GASP_Tkinter/src/branch/main/gasp/gasp.py#L262) line of gasp.py, replace:
`extent=end_angle,`
with:
`extent=end_angle-start_angle,`
This makes the class work the way I expected. I assumed correctly that "extent" meant how far the arc should travel. By subtracting off the start angle, the arc instead ends at the given angle rather than travelling that far. Of course if the previous functionally is meant to stay intact, maybe it could become an option?
Hope this helps.