IDE freeze during refactoring #3

vivraan commented 2026年02月17日 23:49:39 +01:00

I have been having trouble with the Zigbrains crashing and paralysing the IDE whenever I instate a refactor that the plugin cannot account for. I dutifully collect the thread dump and keep going. These crashes are reproducible.

What's the best way to report these kinds of crashes? Should I forward the dumps here or a private email address?

I have been having trouble with the Zigbrains crashing and paralysing the IDE whenever I instate a refactor that the plugin cannot account for. I dutifully collect the thread dump and keep going. These crashes are reproducible. What's the best way to report these kinds of crashes? Should I forward the dumps here or a private email address?

FalsePattern commented 2026年02月23日 18:56:09 +01:00

you can post the thread dumps here, however, refactoring is handled by ZLS through LSP4IJ, so it's probably not caused by ZigBrains directly, but the lsp4ij plugin

you can post the thread dumps here, however, refactoring is handled by ZLS through LSP4IJ, so it's probably not caused by ZigBrains directly, but the lsp4ij plugin

vivraan commented 2026年02月25日 12:30:32 +01:00

Here we go...

About:

CLion 2025.3.1Build #CL-253.29346.141, built on December 18, 2025; skipped licence infoRuntime version: 21.0.9+1-b1163.86 amd64 (JCEF 137.0.17)VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.Toolkit: sun.awt.windows.WToolkitWindows 11.0.NET Core v9.0.11 x64 (Server GC)GC: G1 Young Generation, G1 Concurrent GC, G1 Old GenerationMemory: 16384MCores: 16Registry: actionSystem.update.actions.warn.dataRules.on.edt=false debugger.new.tool.window.layout=true vcs.log.index.enable=true run.processes.with.pty=TRUE ide.experimental.ui=true llm.show.ai.promotion.window.on.start=falseNon-Bundled Plugins: com.falsepattern.zigbrains (29.0.0-253) com.redhat.devtools.lsp4ij (0.19.2) ; skipped other plugin entries

The attached logs appears after this code – I can't copy the buffer of CLion in its crashed state, but I included the scrollbar to indicate where error squiggles show (I know error squiggles are inconsistent):

image

###### Here we go... About: ```ahk CLion 2025年3月1日 Build #CL-253.29346.141, built on December 18, 2025 ; skipped licence info Runtime version: 21.0.9+1-b1163.86 amd64 (JCEF 137.0.17) VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Toolkit: sun.awt.windows.WToolkit Windows 11.0 .NET Core v9.0.11 x64 (Server GC) GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation Memory: 16384M Cores: 16 Registry: actionSystem.update.actions.warn.dataRules.on.edt=false debugger.new.tool.window.layout=true vcs.log.index.enable=true run.processes.with.pty=TRUE ide.experimental.ui=true llm.show.ai.promotion.window.on.start=false Non-Bundled Plugins: com.falsepattern.zigbrains (29.0.0-253) com.redhat.devtools.lsp4ij (0.19.2) ; skipped other plugin entries ``` The attached logs appears after this code – I can't copy the buffer of CLion in its crashed state, but I included the scrollbar to indicate where error squiggles show (I know error squiggles are inconsistent): 

vivraan commented 2026年02月25日 12:31:13 +01:00

Happy to triage this for different crashes.

Happy to triage this for different crashes.

FalsePattern commented 2026年02月25日 16:01:02 +01:00

from what i can see in the thread dumps, zigbrains is getting stuck while initializing the LSP after an lsp4ij call to the builder.
and this is caused by a zig env call never returning properly
i'll look into this more later today, but zigbrains is likely using the wrong thread pool somewhere and starving the IDE which causes a deadlock.

from what i can see in the thread dumps, zigbrains is getting stuck while initializing the LSP after an lsp4ij call to the builder. and this is caused by a `zig env` call never returning properly i'll look into this more later today, but zigbrains is likely using the wrong thread pool somewhere and starving the IDE which causes a deadlock.

FalsePattern commented 2026年02月25日 21:26:16 +01:00

Should be fixed in 29.0.1.

I rewired some of the threading code so the affected part of the logic is now running on an IO thread pool (64 max thread count instead of # of cpu threads), and i also added a 1 second timeout to the spot where the deadlock can happen, so in the worst case, the LSP will just throw a timeout error instead of taking down the whole IDE.

Should be fixed in 29.0.1. I rewired some of the threading code so the affected part of the logic is now running on an IO thread pool (64 max thread count instead of # of cpu threads), and i also added a 1 second timeout to the spot where the deadlock can happen, so in the worst case, the LSP will just throw a timeout error instead of taking down the whole IDE.

FalsePattern commented 2026年02月26日 15:03:33 +01:00

I'll leave the issue open for now, if it no longer happens for the next few days, you can close it

I'll leave the issue open for now, if it no longer happens for the next few days, you can close it

vivraan commented 2026年02月26日 15:05:32 +01:00

Sounds like a plan. I'll test these and revert.

Sounds like a plan. I'll test these and revert.

vivraan commented 2026年02月28日 22:16:32 +01:00

IDE error from 29.0.1, maybe this is the error you are looking for? It appears on launch.
Had to restart twice as a previous error stopped Zigbrains.

com.intellij.diagnostic.PluginException:Thisthreadholdsareadlockwhiletryingtoinvokeamodalprogress.Modalprogressesareallowedonlyunderwrite-intentlockbecausetheyneedtopreventbackgroundwriteactions.Considermovingthismodalprogressoutof`readAction`[Plugin:com.falsepattern.zigbrains]
	at com.intellij.ui.EditorNotificationsImpl$updateEditors$job1ドル.invokeSuspend(EditorNotificationsImpl.kt:285)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:98)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:610)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runDefaultDispatcherTask(CoroutineScheduler.kt:1194)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:906)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:775)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:762)
Caused by:java.lang.IllegalStateException:Thisthreadholdsareadlockwhiletryingtoinvokeamodalprogress.Modalprogressesareallowedonlyunderwrite-intentlockbecausetheyneedtopreventbackgroundwriteactions.Considermovingthismodalprogressoutof`readAction`
	at com.intellij.openapi.progress.impl.PlatformTaskSupport.runWithModalProgressBlockingInternal(PlatformTaskSupport.kt:363)
	at com.intellij.platform.ide.progress.TasksKt.runWithModalProgressBlocking(tasks.kt:205)
	at com.falsepattern.zigbrains.lsp.notification.ZigEditorNotificationProvider.collectNotificationData$lambda0ドル(ZigEditorNotificationProvider.kt:90)
	at com.intellij.ui.EditorNotificationsImpl$updateEditors$job1ドル2ドル.invokeSuspend$lambda0ドル(EditorNotificationsImpl.kt:266)
	at com.intellij.openapi.application.ActionsKt.runReadAction$lambda0ドル(actions.kt:25)
	at com.intellij.platform.locking.impl.NestedLocksThreadingSupport.runReadAction(NestedLocksThreadingSupport.kt:856)
	at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:1064)
	at com.intellij.openapi.application.ActionsKt.runReadAction(actions.kt:25)
	at com.intellij.ui.EditorNotificationsImpl$updateEditors$job1ドル2ドル.invokeSuspend(EditorNotificationsImpl.kt:265)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
	at com.intellij.openapi.application.TransactionGuardImpl2ドル.run(TransactionGuardImpl.java:224)
	at com.intellij.openapi.application.impl.NonBlockingFlushQueue.runNextEvent$lambda4ドル(NonBlockingFlushQueue.kt:358)
	at com.intellij.concurrency.ThreadContext.resetThreadContext(threadContext.kt:294)
	at com.intellij.openapi.application.impl.NonBlockingFlushQueue.runNextEvent(NonBlockingFlushQueue.kt:357)
	at com.intellij.openapi.application.impl.NonBlockingFlushQueue.flushNow(NonBlockingFlushQueue.kt:305)
	at com.intellij.openapi.application.impl.NonBlockingFlushQueue.FLUSH_NOW$lambda0ドル(NonBlockingFlushQueue.kt:167)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:781)
	at java.desktop/java.awt.EventQueue4ドル.run(EventQueue.java:728)
	at java.desktop/java.awt.EventQueue4ドル.run(EventQueue.java:722)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:750)
	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.kt:664)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.kt:517)
	at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda0ドル0ドル0ドル(IdeEventQueue.kt:333)
	at com.intellij.ide.IdeEventQueueKt.performActivity$lambda1ドル(IdeEventQueue.kt:1065)
	at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:109)
	at com.intellij.ide.IdeEventQueueKt.performActivity(IdeEventQueue.kt:1065)
	at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda0ドル(IdeEventQueue.kt:331)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:371)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)

IDE error from 29.0.1, maybe this is the error you are looking for? It appears on launch. Had to restart twice as a previous error stopped Zigbrains. ```termcap com.intellij.diagnostic.PluginException: This thread holds a read lock while trying to invoke a modal progress.Modal progresses are allowed only under write-intent lock because they need to prevent background write actions.Consider moving this modal progress out of `readAction` [Plugin: com.falsepattern.zigbrains] at com.intellij.ui.EditorNotificationsImpl$updateEditors$job1ドル.invokeSuspend(EditorNotificationsImpl.kt:285) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:98) at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:610) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runDefaultDispatcherTask(CoroutineScheduler.kt:1194) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:906) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:775) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:762) Caused by: java.lang.IllegalStateException: This thread holds a read lock while trying to invoke a modal progress.Modal progresses are allowed only under write-intent lock because they need to prevent background write actions.Consider moving this modal progress out of `readAction` at com.intellij.openapi.progress.impl.PlatformTaskSupport.runWithModalProgressBlockingInternal(PlatformTaskSupport.kt:363) at com.intellij.platform.ide.progress.TasksKt.runWithModalProgressBlocking(tasks.kt:205) at com.falsepattern.zigbrains.lsp.notification.ZigEditorNotificationProvider.collectNotificationData$lambda0ドル(ZigEditorNotificationProvider.kt:90) at com.intellij.ui.EditorNotificationsImpl$updateEditors$job1ドル2ドル.invokeSuspend$lambda0ドル(EditorNotificationsImpl.kt:266) at com.intellij.openapi.application.ActionsKt.runReadAction$lambda0ドル(actions.kt:25) at com.intellij.platform.locking.impl.NestedLocksThreadingSupport.runReadAction(NestedLocksThreadingSupport.kt:856) at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:1064) at com.intellij.openapi.application.ActionsKt.runReadAction(actions.kt:25) at com.intellij.ui.EditorNotificationsImpl$updateEditors$job1ドル2ドル.invokeSuspend(EditorNotificationsImpl.kt:265) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100) at com.intellij.openapi.application.TransactionGuardImpl2ドル.run(TransactionGuardImpl.java:224) at com.intellij.openapi.application.impl.NonBlockingFlushQueue.runNextEvent$lambda4ドル(NonBlockingFlushQueue.kt:358) at com.intellij.concurrency.ThreadContext.resetThreadContext(threadContext.kt:294) at com.intellij.openapi.application.impl.NonBlockingFlushQueue.runNextEvent(NonBlockingFlushQueue.kt:357) at com.intellij.openapi.application.impl.NonBlockingFlushQueue.flushNow(NonBlockingFlushQueue.kt:305) at com.intellij.openapi.application.impl.NonBlockingFlushQueue.FLUSH_NOW$lambda0ドル(NonBlockingFlushQueue.kt:167) at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318) at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:781) at java.desktop/java.awt.EventQueue4ドル.run(EventQueue.java:728) at java.desktop/java.awt.EventQueue4ドル.run(EventQueue.java:722) at java.base/java.security.AccessController.doPrivileged(AccessController.java:400) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87) at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:750) at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.kt:664) at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.kt:517) at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda0ドル0ドル0ドル(IdeEventQueue.kt:333) at com.intellij.ide.IdeEventQueueKt.performActivity$lambda1ドル(IdeEventQueue.kt:1065) at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:109) at com.intellij.ide.IdeEventQueueKt.performActivity(IdeEventQueue.kt:1065) at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda0ドル(IdeEventQueue.kt:331) at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:371) at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207) at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128) at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105) at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92) ```

FalsePattern commented 2026年04月03日 09:46:49 +02:00

That plugin exception should be fixed in 30.0.0

That plugin exception should be fixed in 30.0.0

vivraan commented 2026年04月03日 11:30:10 +02:00

Will test and report here!

Will test and report here!

vivraan commented 2026年04月04日 23:24:43 +02:00

Looks okay, no further logs or errors so far. Will close this issue with this comment.

Looks okay, no further logs or errors so far. Will close this issue with this comment.

3 hours 14 minutes