1
1
Fork
You've already forked minisign4j
0

Replace wasm hardcoupled api with factory pattern #1

Closed
opened 2026年04月15日 08:51:24 +02:00 by FalsePattern · 1 comment

The wasm implementation should be an implementation detail for compatibility with the eventual switch to a pure java implementation.
Currently the front facing apis are all classes with embedded wasm fields, which is annoying.

Solutions:

  • Replace the public-facing api classes with sealed interfaces
  • Add a factory class that provides implementations of these apis

The sealedness may be relaxed in the future once the api structure is more finalized.

The wasm implementation should be an implementation detail for compatibility with the eventual switch to a pure java implementation. Currently the front facing apis are all classes with embedded wasm fields, which is annoying. Solutions: - Replace the public-facing api classes with sealed interfaces - Add a factory class that provides implementations of these apis The sealedness may be relaxed in the future once the api structure is more finalized.
Author
Owner
Copy link

No longer relevant, i decided to go with the full port route instead.

No longer relevant, i decided to go with the full port route instead.
Sign in to join this conversation.
No Branch/Tag specified
master
1.0.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#2 Publish to Maven Central
FalsePattern/minisign4j
Reference
FalsePattern/minisign4j#1
Reference in a new issue
FalsePattern/minisign4j
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?