It looks like fields that are left empty still have buttons created, contrary to what the general guidelines suggest. So either the instructions in the readme would have to change and all existing entries stripped of empty fields, or these fields should be ignored during site generation as implied in the readme.
FOSSgaming/pages-data
Empty fields not ignored #5
Closed
opened 2025年02月26日 08:29:11 +01:00 by Modanung
·
3 comments
Modanung
commented 2025年02月26日 08:29:11 +01:00
It looks like fields that are left empty still have buttons created, contrary to what the [general guidelines](https://codeberg.org/FOSSgaming/pages-data#general-guidelines) suggest. So either the instructions in the readme would have to change and all existing entries stripped of empty fields, or these fields should be ignored during site generation as implied in the readme.
nightm4re
commented 2025年02月26日 09:13:33 +01:00
Good catch! I think I should've phrased the README a bit clearer here: what I meant was to omit empty fields entirely, not just leave them blank. But we can totally make the site generation consider blank fields as well so both cases work.
Good catch! I think I should've phrased the README a bit clearer here: what I meant was to omit empty fields entirely, not just leave them blank. But we can totally make the site generation consider blank fields as well so both cases work.
Modanung
commented 2025年02月26日 09:48:31 +01:00
- Some projects may not have feeds for all categories. In such cases, leave the corresponding section empty.
To me, this clearly suggests including the fields with no value, not leaving them out.
So will you change the site generation so that blank fields are ignored? Then I won't issue a PR removing empty fields.
> - Some projects may not have feeds for all categories. In such cases, leave the corresponding section empty.
To me, this clearly suggests _including_ the fields with no value, _not_ leaving them out.
So will you change the site generation so that blank fields are ignored? Then I won't issue a PR removing empty fields.
nightm4re
commented 2025年02月26日 10:47:53 +01:00
I'll take care of ignoring empty fields 👍
I'll take care of ignoring empty fields 👍
nightm4re
closed this issue 2025年02月26日 22:15:07 +01:00
Sign in to join this conversation.
Labels
Clear labels
bug
Something is not working
community
Issues related to community management
contribution welcome
Contributions are very welcome, get started here
duplicate
This issue or pull request already exists
engine
Issues related to engine projects
enhancement
New feature
game
Issues related to game projects
good first issue
Interested in contributing? Get started here.
help wanted
Need some help
invalid
Something is wrong
missing-projects
Use this label to request missing games and engines in the database
performance
Issues related to site performance and speed
question
More information is needed
responsiveness
Issues related to responsiveness
script
Issues related to scripts
styling
Issues related to CSS styling
templates
Issues related to Nunjucks templates
tool
Issues related to tool projects
upstream
Related to an upstream repository, already reported there
No labels
bug
community
contribution welcome
duplicate
engine
enhancement
game
good first issue
help wanted
invalid
missing-projects
performance
question
responsiveness
script
styling
templates
tool
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
FOSSgaming/pages-data#5
Loading...
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?