Save configuration in extra file #34

DerEntwickler commented 2022年01月02日 17:42:44 +01:00

Dear developer,
thank you for your helpful backup and restore script.
Here my feature request for easy handling:

I would prefere to use a separate "configuration"-file to configure the nessesary variables.
For example you can implement this by using a separate config.file and include this for backup and restore script.

If you need some idears how to do so, pleas ask.

Dear developer, thank you for your helpful backup and restore script. Here my feature request for easy handling: I would prefere to use a separate "configuration"-file to configure the nessesary variables. For example you can implement this by using a separate config.file and include this for backup and restore script. If you need some idears how to do so, pleas ask.

DecaTec commented 2022年01月03日 11:47:16 +01:00

I want to keep these scripts as simple as possible. So all the configuration is contained in the scripts. Use setup.sh in order to set the variables needed in the backup and restore scripts.
Using a configuration file and call the scripts with a parameter specifying the configuration would make the system a little more complex imho.

But feel free to create a PR when you got a good and sinmple solution.

I want to keep these scripts as simple as possible. So all the configuration is contained in the scripts. Use `setup.sh` in order to set the variables needed in the backup and restore scripts. Using a configuration file and call the scripts with a parameter specifying the configuration would make the system a little more complex imho. But feel free to create a PR when you got a good and sinmple solution.

MegaV0lt commented 2022年01月04日 11:04:59 +01:00

I made a attempt to keep config in one file and added a pull request:
#36

Please check. It is not tested

I made a attempt to keep config in one file and added a pull request: https://codeberg.org/DecaTec/Nextcloud-Backup-Restore/pulls/36 Please check. It is not tested

DecaTec commented 2022年01月09日 14:49:12 +01:00

I've merged the open PR by @MegaV0lt into a separate branch:
https://codeberg.org/DecaTec/Nextcloud-Backup-Restore/src/branch/config-file

Some work had to be done after that, but the scripts now work after being set up by the setup script.

Please give it a try and provide some feedback.

I've merged the open PR by @MegaV0lt into a separate branch: https://codeberg.org/DecaTec/Nextcloud-Backup-Restore/src/branch/config-file Some work had to be done after that, but the scripts now work after being set up by the setup script. Please give it a try and provide some feedback.

DecaTec commented 2022年01月14日 12:25:50 +01:00

Was anyone able to test the version from the new branch?

Was anyone able to test the version from the new branch?

DerEntwickler commented 2022年01月14日 12:36:35 +01:00

Was anyone able to test the version from the new branch?

The db-password is now correct. woks fine here. good work and thx.

> Was anyone able to test the version from the new branch? The db-password is now correct. woks fine here. good work and thx.

DecaTec commented 2022年01月14日 12:53:45 +01:00

OK, i'll make a few more tests and prepare for a new release then.

OK, i'll make a few more tests and prepare for a new release then.

DecaTec commented 2022年01月15日 12:39:13 +01:00

v3.0.0 now released: https://codeberg.org/DecaTec/Nextcloud-Backup-Restore/releases/tag/v3.0.0

I'll close this one.

v3.0.0 now released: https://codeberg.org/DecaTec/Nextcloud-Backup-Restore/releases/tag/v3.0.0 I'll close this one.