Run lint and format:check via workflow (and fix lint and format issues) #224

bobidle commented 2026年07月09日 00:03:29 +02:00

When running pnpm lint or pnpm format:check locally a lot of issues are shown.

e.g. pnpm format (prettier) produceses the following diff: #223/files

e.g. pnpm lint (eslint) shows the following issues:

> eslint .
/test/packages/admin/src/cms.tsx
 33:44 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
 68:34 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
 217:41 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
 247:31 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
 342:33 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
 374:27 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
/test/src/components/sections/FeaturedGuidesSection.astro
 10:11 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
/test/src/integrations/asset-manifest.js
 25:7 warning 'IMAGE_EXTENSIONS' is assigned a value but never used @typescript-eslint/no-unused-vars
/test/src/integrations/map-snapshot.ts
 187:19 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
 191:16 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
/test/src/layouts/GuideLayout.astro
 44:3 warning 'slug' is assigned a value but never used @typescript-eslint/no-unused-vars
 81:7 warning 'totalSteps' is assigned a value but never used @typescript-eslint/no-unused-vars
✖ 12 problems (0 errors, 12 warnings)

I would like to fix these issues and add pnpm lint and pnpm format:check to an existing workflow.

1. Would that make any sense for the website?
2. Does eslint or prettier need an additional config to fit to the current code style/format?

When running `pnpm lint` or `pnpm format:check` locally a lot of issues are shown. e.g. `pnpm format` (prettier) produceses the following diff: https://codeberg.org/DI-Day/website/pulls/223/files e.g. `pnpm lint` (eslint) shows the following issues: ``` > eslint . /test/packages/admin/src/cms.tsx 33:44 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any 68:34 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any 217:41 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any 247:31 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any 342:33 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any 374:27 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any /test/src/components/sections/FeaturedGuidesSection.astro 10:11 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any /test/src/integrations/asset-manifest.js 25:7 warning 'IMAGE_EXTENSIONS' is assigned a value but never used @typescript-eslint/no-unused-vars /test/src/integrations/map-snapshot.ts 187:19 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any 191:16 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any /test/src/layouts/GuideLayout.astro 44:3 warning 'slug' is assigned a value but never used @typescript-eslint/no-unused-vars 81:7 warning 'totalSteps' is assigned a value but never used @typescript-eslint/no-unused-vars ✖ 12 problems (0 errors, 12 warnings) ``` I would like to fix these issues and add `pnpm lint` and `pnpm format:check` to an existing workflow. 1) Would that make any sense for the website? 2) Does eslint or prettier need an additional config to fit to the current code style/format?