Codeberg/pages-server
25
366
Fork
You've already forked pages-server
52

6.1 broke compression #404

Closed
opened 2024年11月22日 17:07:49 +01:00 by ltdk · 2 comments
Contributor
Copy link

Just posting as a new issue so it doesn't get lost: #403 broke the changes added by #387 in a way that does not degrade gracefully. If you don't remove the compressed versions of files from your branch, it will serve them as raw compressed files without the Content-Encoding header, effectively making them not viewable in the browser. Additionally, even if you do this, it won't purge the cache for these files and you'll have to wait for cache to expire before they start serving correctly.

As I mentioned in my comments on #403, I'm fine with reverting the original changes for #387 to ensure that #403 remains in production (since, I'm assuming it was done to reduce server load), but I'm not fine keeping it in this broken state.

Just posting as a new issue so it doesn't get lost: #403 broke the changes added by #387 in a way that does not degrade gracefully. If you don't remove the compressed versions of files from your branch, it will serve them as raw compressed files without the `Content-Encoding` header, effectively making them not viewable in the browser. Additionally, even if you do this, it won't purge the cache for these files and you'll have to wait for cache to expire before they start serving correctly. As I mentioned in my comments on #403, I'm fine with reverting the original changes for #387 to ensure that #403 remains in production (since, I'm assuming it was done to reduce server load), but I'm not fine keeping it in this broken state.

I will fix this tomorrow to get back the functionality you added. Sorry for breaking it 😅

I will fix this tomorrow to get back the functionality you added. Sorry for breaking it 😅
Author
Contributor
Copy link

Thank you! If you have any questions about the code, feel free to ask. <3

Thank you! If you have any questions about the code, feel free to ask. <3
Sign in to join this conversation.
No Branch/Tag specified
main
renovate/woodpeckerci-plugin-docker-buildx-6.x
renovate/golang-deps-non-major
git-pages-server-doc
pages
ci_user-local-acme-service
feat/redis-caching
fix/memory-problem
v6.4
v6.3
v6.2.1
v6.2
v6.1
v6.0
v5.1
v5.0
v4.6.3
v4.6.2
v4.6.1
v4.6
v4.5
v4.4
v4.3
v4.2
v4.1
v4.0
v3.2.1
v3.2
v0.3.1
v0.3.0
v0.2.2
v0.2.1
v3.1
v3.0a
v3.0
v2.5b
v2.5a
v2.5
v2.4
v2.3
v2.2
v2.1
v2.0
v1.0_php
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/pages-server#404
Reference in a new issue
Codeberg/pages-server
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?